Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem matcher rooted file path from container action does not work #269

Closed
ericsciple opened this issue Jan 13, 2020 · 7 comments · Fixed by #272
Closed

Problem matcher rooted file path from container action does not work #269

ericsciple opened this issue Jan 13, 2020 · 7 comments · Fixed by #272
Assignees
@ericsciple
Labels
bug Something isn't working
Milestone
2.164.1

Comments

@ericsciple
Copy link
Collaborator

ericsciple commented Jan 13, 2020 •
edited
Loading

refer to actions/toolkit#224 (comment)
@ericsciple ericsciple added the bug Something isn't working label Jan 13, 2020
@ericsciple ericsciple self-assigned this Jan 13, 2020
@ericsciple
Copy link
Collaborator Author

ericsciple commented Jan 13, 2020 •
edited
Loading

Working on a fix... should be pretty small, will finish testing tomorrow.

Looking at the code, this might also be a problem with job container. Test that scenario too.

@ericsciple
Copy link
Collaborator Author

@edhgoose fyi

@ericsciple ericsciple mentioned this issue Jan 13, 2020
Merged
@ericsciple ericsciple added this to the 2.164.1 milestone Jan 14, 2020
@edhgoose
Copy link

Thank you @ericsciple! Is that change now deployed (if not, when will I know it is)? I'll give it a spin and see if its working for me as hoped!

@ericsciple
Copy link
Collaborator Author

Not deployed yet. v2.164.0 is going out soon. Based on typical rhythm, I would expect 2.164.1 to be next week or the week after.

@edhgoose
Copy link

edhgoose commented Feb 3, 2020

Hi @ericsciple - just checking in as I haven't seen this mentioned in the release notes, am I safe in assuming this is on production now?

I'm unfortunately not seeing it working for me. Any ideas on how I can check what's failing?

@TingluoHuang
Copy link
Member

@edhgoose it's part of 2.165.0/1 runner and it's about to release.

@edhgoose
Copy link

edhgoose commented Feb 3, 2020 via email

@thboop thboop mentioned this issue Mar 11, 2020
Closed
@frenck frenck mentioned this issue Jul 4, 2020
Merged
20 tasks
@electronjoe electronjoe mentioned this issue Mar 12, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericsciple ericsciple

Labels
bug Something isn't working
Projects
None yet
Milestone
2.164.1
Development

Successfully merging a pull request may close this issue.

translate problem matcher file to host path actions/runner
3 participants
@edhgoose @TingluoHuang @ericsciple