Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Adopt Open JDK for Ubuntu. #1060

Merged
merged 11 commits into from
Jun 24, 2020
Merged

Add Adopt Open JDK for Ubuntu. #1060

merged 11 commits into from
Jun 24, 2020

Conversation

Darleev
Copy link
Contributor

@Darleev Darleev commented Jun 16, 2020

Description

Improvement
Description: #1057

Related issue:

https://github.com/actions/virtual-environments-internal/issues/685

Check list

  • [+] Related issue / work item is attached
  • [+] Documentation is updated (if applicable)
  • [+] Changes are tested and related VM images are successfully generated

@Darleev Darleev requested a review from al-cheb June 16, 2020 18:50
@al-cheb
Copy link
Contributor

al-cheb commented Jun 16, 2020

DocumentInstalledItem "Azul Zulu OpenJDK:" - Line 98

@Darleev Darleev requested a review from vmapetr June 16, 2020 19:13
@Darleev Darleev requested review from al-cheb and maxim-lobanov June 17, 2020 07:23
@miketimofeev
Copy link
Contributor

@maxim-lobanov @Darleev 2 notes:

  1. We decided to get rid of Java12 in the scope of Adopt JDK
    Add Ubuntu 20 image #883 (comment)
  2. It was proposed to switch default Java version to 11
    Add Ubuntu 20 image #883 (comment)

@maxim-lobanov
Copy link
Contributor

@maxim-lobanov @Darleev 2 notes:

  1. We decided to get rid of Java12 in the scope of Adopt JDK
    #883 (comment)
  2. It was proposed to switch default Java version to 11
    #883 (comment)

@miketimofeev , @Darleev
We can't do any of them in scope of this PR and this feature since it is a breaking change.

@miketimofeev
Copy link
Contributor

miketimofeev commented Jun 17, 2020

@maxim-lobanov @Darleev 2 notes:

  1. We decided to get rid of Java12 in the scope of Adopt JDK
    #883 (comment)
  2. It was proposed to switch default Java version to 11
    #883 (comment)

@miketimofeev , @Darleev
We can't do any of them in scope of this PR and this feature since it is a breaking change.

@alepauly is it ok for you if we make the changes outside of this PR?

@maxim-lobanov
Copy link
Contributor

@maxim-lobanov @Darleev 2 notes:

  1. We decided to get rid of Java12 in the scope of Adopt JDK
    #883 (comment)
  2. It was proposed to switch default Java version to 11
    #883 (comment)

@miketimofeev , @Darleev
We can't do any of them in scope of this PR and this feature since it is a breaking change.

@alepauly is it ok for you if we make the changes outside of this PR?

I don't think that we want to do these changes in near future.
Java size is pretty small and removing Java 12 won't give significant win.
But impact could be pretty huge, especially from switching default version

@maxim-lobanov
Copy link
Contributor

/azp run ubuntu1604, ubuntu1804, ubuntu2004

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@alepauly
Copy link
Contributor

I don't think that we want to do these changes in near future.
Java size is pretty small and removing Java 12 won't give significant win.
But impact could be pretty huge, especially from switching default version

We can discuss/do it as separate work. The main reason of getting rid of Java 12 is that it sets the expectation that those intermediate versions will be available. I rather have setup-java and useJava deal with that. Once those download on demand we should be able to remove any version (communicating prior that Actions/Task is recommended method).

We'll eventually have to switch to Java 11 as default but I'm not sure the time is right. Perhaps we can see version usage through setup-java/useJava and that will tell us when we should.

@AlenaSviridenko
Copy link
Contributor

/azp run ubuntu1604, ubuntu1804, ubuntu2004

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@maxim-lobanov
Copy link
Contributor

/azp run ubuntu1604, ubuntu1804, ubuntu2004

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@Darleev Darleev requested a review from maxim-lobanov June 23, 2020 18:08
@maxim-lobanov
Copy link
Contributor

/azp run ubuntu1604, ubuntu1804, ubuntu2004

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@maxim-lobanov maxim-lobanov merged commit f342a7d into actions:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants