Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ubuntu 20.04: Update docker-compose-plugin to v2.20.0 #7916

Closed
2 of 10 tasks
aarongable opened this issue Jul 13, 2023 · 3 comments
Closed
2 of 10 tasks

Ubuntu 20.04: Update docker-compose-plugin to v2.20.0 #7916

aarongable opened this issue Jul 13, 2023 · 3 comments
Labels
Area: Containers awaiting-deployment Code complete; awaiting deployment and/or deployment in progress bug report OS: Ubuntu

Comments

@aarongable
Copy link

Description

The current Ubuntu 20.04 image appears to be using v2.19.1 of docker-compose-plugin. Unfortunately, this version has a debilitating regression which causes containers to often only connect to one of their networks. This causes flaky failures in docker compose setups that require multiple networks to function properly.

Please update the docker-compose-plugin version to v2.20.0 to bring in the fix.

Platforms affected

  • Azure DevOps
  • GitHub Actions - Standard Runners
  • GitHub Actions - Larger Runners

Runner images affected

  • Ubuntu 20.04
  • Ubuntu 22.04
  • macOS 11
  • macOS 12
  • macOS 13
  • Windows Server 2019
  • Windows Server 2022

Image version and build link

Sample run: https://github.com/letsencrypt/boulder/actions/runs/5545851751/jobs/10125357707
Runner image version: 20230710.1.0

Is it regression?

Yes, 20230702.1.0, https://github.com/letsencrypt/boulder/actions/runs/5520825838/jobs/10068018921

Expected behavior

Containers should come up and connect to all of their networks.

Actual behavior

Containers sometimes connect to only one of their networks, making various services unreachable and causing tests to fail.

Repro steps

  1. Have a docker-compose.yml which creates containers that connect to multiple networks
    example: https://github.com/letsencrypt/boulder/blob/main/docker-compose.yml
  2. Have a github actions job which runs on Ubuntu 20.04 and uses docker-compose-plugin to start the containers
    example: https://github.com/letsencrypt/boulder/blob/main/.github/workflows/boulder-ci.yml
  3. Run the workflow on a recent build of the ubuntu 20.04 image
This was referenced Jul 13, 2023
Closed
Merged
pgporada pushed a commit to letsencrypt/boulder that referenced this issue Jul 13, 2023
@aarongable
Install v2.20.0 of docker-compose-plugin (#6997)
944a865 
Work around the bug[1] in docker-compose-plugin v2.19.1, which is
included in the current github actions ubuntu 20.04 runner image[2].

[1] docker/compose#10777
[2] actions/runner-images#7916

Part of #6998
@Alexey-Ayupov
Copy link
Collaborator

Hello @aarongable, the new version of docker compose will be available in our next release the next week.

@Alexey-Ayupov Alexey-Ayupov added Area: Containers OS: Ubuntu awaiting-deployment Code complete; awaiting deployment and/or deployment in progress and removed needs triage labels Jul 14, 2023
@WIStudent
Copy link

The same issue with the docker compose version also occurs on the current Ubuntu 22.04 image.

@sergei-pyshnoi
Copy link
Contributor

Docker-compose v.2.20.0 is available for both Ubuntu images

@aarongable aarongable mentioned this issue Aug 1, 2023
Merged
pgporada pushed a commit to letsencrypt/boulder that referenced this issue Aug 2, 2023
@aarongable
Revert "Install v2.20.0 of docker-compose-plugin" (#7019)
2ecd370 
Reverts #6997, which manually
installed a specific version of the docker compose cli plugin to work
around a bug in the version installed by default. The images now ship
the fixed version by default
(actions/runner-images#7916 (comment)),
so we can remove the workaround.

Fixes #6998
rce added a commit to Opetushallitus/rekisterointi that referenced this issue Aug 13, 2024
@rce
Switch 'docker-compose' to 'docker compose'
05803bd 
actions/runner-images#7916
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Containers awaiting-deployment Code complete; awaiting deployment and/or deployment in progress bug report OS: Ubuntu
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@aarongable @WIStudent @Alexey-Ayupov @sergei-pyshnoi