Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg-config was removed from macos-latest runners #7159

Closed
1 of 10 tasks
cavokz opened this issue Feb 20, 2023 · 2 comments
Closed
1 of 10 tasks

pkg-config was removed from macos-latest runners #7159

cavokz opened this issue Feb 20, 2023 · 2 comments
Labels
bug report

Comments

@cavokz
Copy link

cavokz commented Feb 20, 2023

Description

Since (probably) d7312cf pkg-config is not present any more in the macos-latest runners. Nothing is mentioned in the version tracking though.

Platforms affected

  • Azure DevOps
  • GitHub Actions - Standard Runners
  • GitHub Actions - Larger Runners

Runner images affected

  • Ubuntu 18.04
  • Ubuntu 20.04
  • Ubuntu 22.04
  • macOS 11
  • macOS 12
  • Windows Server 2019
  • Windows Server 2022

Image version and build link

Broken

Runner image version: 20230214.2
Job link: https://github.com/elastic/geneve/actions/runs/4225687985/jobs/7338324192

Working

Runner image version: 20230205.1
Job link: https://github.com/elastic/geneve/actions/runs/4196117124/jobs/7277667028

Is it regression?

See "Working" above.

Expected behavior

A build using pkg-config does not fail because of missing pkg-config.

Actual behavior

A build using pkg-config fails:

pkg-config: exec: "pkg-config": executable file not found in $PATH

Repro steps

Follow my "broken job link" above and press "re-run all failed jobs".
@erik-bershel
Copy link
Contributor

You can track that issue here: #7128
PR merged: #7125

@andreasabel
Copy link

@ mikhailkoliada : PR #7125 fixed this but did not seem to add any tests.
If a tool like pkg-config can disappear just like this from the image, then it looks like you do not have enough tests.
A minimal test would invoke just pkg-config --version to see that the program is at least present.

Without regression tests, you will play whack-a-mole in all eternity.

@andreasabel andreasabel mentioned this issue Feb 20, 2023
Merged
friendlyanon added a commit to friendlyanon/cmake-init that referenced this issue Mar 15, 2023
@friendlyanon
Remove install step for pkg-config on macos
fd3cdf3 
This was a hastily put together fix anyway. The removal of this tool
from the image seems to have been by mistake.

See actions/runner-images#7159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cavokz @andreasabel @mikhailkoliada @erik-bershel