ANDROID_NDK_ROOT environment variable should be preset #2426
Assignees
Labels
awaiting-deployment
Code complete; awaiting deployment and/or deployment in progress
feature request
OS: macOS
OS: Ubuntu
OS: Windows
Comments
|
vote for this feature! |
2 tasks
|
The PR has been merged. The new environment variables will be available after the next vm rollout. |
miketimofeev
added
OS: Ubuntu
awaiting-deployment
|
ANDROID_NDK_ROOT variable is now available across all the images |
Closed
10 tasks
nappairam
pushed a commit
to nappairam/liboqs-rust
that referenced
this issue
Aug 3, 2024
Based on the cmake manual, cross compiling for Android, https://cmake.org/cmake/help/latest/manual/cmake-toolchains.7.html#cross-compiling-for-android-with-the-ndk CMAKE_SYSTEM_NAME **must** be set to Android. Additionally, set CMAKE_ANDROID_NDK if corresponding env var is available. Android ecosystem uses both ANDROID_NDK_ROOT and ANDROID_NDK_HOME to refer to NDK's path. For example, github runners has both variables set: actions/runner-images#2426 These two cmake variables are sufficient to build for Android with cargo-ndk tool.
nappairam
pushed a commit
to nappairam/liboqs-rust
that referenced
this issue
Aug 6, 2024
Based on the cmake manual, cross compiling for Android, https://cmake.org/cmake/help/latest/manual/cmake-toolchains.7.html#cross-compiling-for-android-with-the-ndk CMAKE_SYSTEM_NAME **must** be set to Android. Additionally, set CMAKE_ANDROID_NDK if corresponding env var is available. Android ecosystem uses both ANDROID_NDK_ROOT and ANDROID_NDK_HOME to refer to NDK's path. For example, github runners has both variables set: actions/runner-images#2426 These two cmake variables are sufficient to build for Android with cargo-ndk tool.
nappairam
pushed a commit
to nappairam/liboqs-rust
that referenced
this issue
Aug 6, 2024
Based on the cmake manual, cross compiling for Android, https://cmake.org/cmake/help/latest/manual/cmake-toolchains.7.html#cross-compiling-for-android-with-the-ndk CMAKE_SYSTEM_NAME **must** be set to Android. Additionally, set CMAKE_ANDROID_NDK if corresponding env var is available. Android ecosystem uses both ANDROID_NDK_ROOT and ANDROID_NDK_HOME to refer to NDK's path. For example, github runners has both variables set: actions/runner-images#2426 These two cmake variables are sufficient to build for Android with cargo-ndk tool.
nappairam
added a commit
to nappairam/liboqs-rust
that referenced
this issue
Aug 6, 2024
Based on the cmake manual, cross compiling for Android, https://cmake.org/cmake/help/latest/manual/cmake-toolchains.7.html#cross-compiling-for-android-with-the-ndk CMAKE_SYSTEM_NAME **must** be set to Android. Additionally, set CMAKE_ANDROID_NDK if corresponding env var is available. Android ecosystem uses both ANDROID_NDK_ROOT and ANDROID_NDK_HOME to refer to NDK's path. For example, github runners has both variables set: actions/runner-images#2426 These two cmake variables are sufficient to build for Android with cargo-ndk tool. Signed-off-by: Mariappan Ramasamy <[email protected]>
nappairam
added a commit
to nappairam/liboqs-rust
that referenced
this issue
Aug 6, 2024
Based on the cmake manual, cross compiling for Android, https://cmake.org/cmake/help/latest/manual/cmake-toolchains.7.html#cross-compiling-for-android-with-the-ndk CMAKE_SYSTEM_NAME **must** be set to Android. Additionally, set CMAKE_ANDROID_NDK if corresponding env var is available. Android ecosystem uses both ANDROID_NDK_ROOT and ANDROID_NDK_HOME to refer to NDK's path. For example, github runners has both variables set: actions/runner-images#2426 These two cmake variables are sufficient to build for Android with cargo-ndk tool. Signed-off-by: Mariappan Ramasamy <[email protected]>
nappairam
added a commit
to nappairam/liboqs-rust
that referenced
this issue
Aug 6, 2024
Based on the cmake manual, cross compiling for Android, https://cmake.org/cmake/help/latest/manual/cmake-toolchains.7.html#cross-compiling-for-android-with-the-ndk CMAKE_SYSTEM_NAME **must** be set to Android. Additionally, set CMAKE_ANDROID_NDK if corresponding env var is available. Android ecosystem uses both ANDROID_NDK_ROOT and ANDROID_NDK_HOME to refer to NDK's path. For example, github runners has both variables set: actions/runner-images#2426 These two cmake variables are sufficient to build for Android with cargo-ndk tool. Signed-off-by: Mariappan Ramasamy <[email protected]>
nappairam
added a commit
to nappairam/liboqs-rust
that referenced
this issue
Aug 6, 2024
Based on the cmake manual, cross compiling for Android, https://cmake.org/cmake/help/latest/manual/cmake-toolchains.7.html#cross-compiling-for-android-with-the-ndk CMAKE_SYSTEM_NAME **must** be set to Android. Additionally, set CMAKE_ANDROID_NDK if corresponding env var is available. Android ecosystem uses both ANDROID_NDK_ROOT and ANDROID_NDK_HOME to refer to NDK's path. For example, github runners has both variables set: actions/runner-images#2426 These two cmake variables are sufficient to build for Android with cargo-ndk tool. Signed-off-by: Mariappan Ramasamy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Add
ANDROID_NDK_HOMEandANDROID_NDK_ROOTto the all images. According to discussion:ANDROID_NDK_HOMEandANDROID_NDK_ROOTare widely used by many other softwares. In most cases, IfANDROID_NDK_HOMEis not defined, the value inANDROID_NDK_ROOTis used. but some software only useANDROID_NDK_HOME, others only useANDROID_NDK_ROOT. so, both are preset is the best.References:
Question, Bug, or Feature?:
Feature request
Virtual environments affected
The text was updated successfully, but these errors were encountered: