Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker-compose not actually installed #10451

Closed
3 of 13 tasks
shawaj opened this issue Aug 17, 2024 · 15 comments
Closed
3 of 13 tasks

Docker-compose not actually installed #10451

shawaj opened this issue Aug 17, 2024 · 15 comments

Comments

@shawaj
Copy link

shawaj commented Aug 17, 2024

Description

This image says it has docker compose installed. https://github.com/actions/runner-images/blob/ubuntu22/20240811.1/images/ubuntu/Ubuntu2204-Readme.md

However it actually doesn't, as when I try to run docker-compose config -q it gives me an error...

/bin/sh: 1: docker-compose: not found

If I run sudo apt-get install docker-compose at the beginning of the action then the action completes fine but if not then it fails.

This is a regression because it used to work fine until last couple of weeks.

Platforms affected

  • Azure DevOps
  • GitHub Actions - Standard Runners
  • GitHub Actions - Larger Runners

Runner images affected

  • Ubuntu 20.04
  • Ubuntu 22.04
  • Ubuntu 24.04
  • macOS 12
  • macOS 13
  • macOS 13 Arm64
  • macOS 14
  • macOS 14 Arm64
  • Windows Server 2019
  • Windows Server 2022

Image version and build link

Version: 20240811.1.0

Is it regression?

Yes

Expected behavior

Docker compose should work

Actual behavior

Docker compose not found

Repro steps

Described above

@vidyasagarnimmagaddi
Copy link
Contributor

Hi @shawaj , We will be analysing the issue and revert with our analysis.thanks

@ijunaidm
Copy link
Contributor

@shawaj - As of now Docker-compose v1 version is completely deprecated from all the images, you have to use docker-compose v2 version .

@shawaj
Copy link
Author

shawaj commented Aug 19, 2024

@shawaj - As of now Docker-compose v1 version is completely deprecated from all the images, you have to use docker-compose v2 version .

This is an absurd change. Remove it from new images sure but existing ones shouldn't have regressions like this.

As an alternative, I don't see any reason why docker-compose command can't be linked to the new command docker compose.

You are just breaking people's actions for no good reason.

@quesurifn
Copy link

I agree with @shawaj. This really affected many teams that were not using the new docker API. It broke without much warning and suddenly. This is generally what engineering teams try to avoid.

@shawaj
Copy link
Author

shawaj commented Aug 20, 2024

I agree with @shawaj. This really affected many teams that were not using the new docker API. It broke without much warning and suddenly. This is generally what engineering teams try to avoid.

💯

This was not communicated in any effective way to people that use this daily

@quesurifn
Copy link

quesurifn commented Aug 20, 2024

@shawaj Are you guys experiencing the added pleasure of debugging docker compose DNS issues? All of our docker compose network settings suddenly broke. We fixed with static IP two weeks ago and this morning PRs were put up and the runner failed again with the static IP fix.

@shawaj
Copy link
Author

shawaj commented Aug 20, 2024

@shawaj Are you guys experiencing the added pleasure of debugging docker compose DNS issues? All of our docker compose network settings suddenly broke. We fixed with static IP two weeks ago and this morning PRs were put up and the runner failed again with the static IP fix.

Not something we use TBH. But I feel for you because that sounds like a massive pain!

I get that stuff has to be updated but it should be properly communicated. The first time you hear about it shouldn't be when your actions fail. Doesn't matter if it's a free service or not...

Cloudflare is the best I've experienced in this kind of thing... Very good communication and updates

@ijunaidm
Copy link
Contributor

@shawaj - Please refer to the below announcement open ticket issue created for the Docker-compose v1 deprecation .
#9692

@shawaj
Copy link
Author

shawaj commented Aug 20, 2024

@shawaj - Please refer to the below announcement open ticket issue created for the Docker-compose v1 deprecation . #9692

Totally useless. But nice try

@quesurifn
Copy link

quesurifn commented Aug 20, 2024

@ijunaidm Again, I agree with @shawaj. There needs to be a banner on Github announcing such a breaking change. Otherwise the proper way to handle in the scope of the development team was to retag the image and document the change in the new runner tag so people's CI/CD doesn't break overnight and people can migrate at will instead of waking up to a fire drill.

I have not met one engineering team that periodically went though the Github issues for all of their likely thousands of dependencies just to keep up to date on the latest breaking changes. That kind of flies in the face of semantic versioning and image tagging and such. How this was handled was not a best practice by any measure. Please do better!

@ijunaidm
Copy link
Contributor

Sure @quesurifn.

Thank you @shawaj @quesurifn . I am closing this ticket issue.

@shawaj
Copy link
Author

shawaj commented Aug 23, 2024

Sure @quesurifn.

Thank you @shawaj @quesurifn . I am closing this ticket issue.

So you are not going to fix this regression? Is that correct?

@ijunaidm
Copy link
Contributor

ijunaidm commented Aug 23, 2024

@shawaj - I completely understand the pain for breaking changes. But we did announced about the v1 deprecation in this ticket #9692

Please try replacing docker-compose with docker compose to fix your issue.

@ijunaidm
Copy link
Contributor

@shawaj - Did replacing docker-compose with docker composr worked for you ?

@ijunaidm
Copy link
Contributor

@shawaj - Thank you , I am closing this ticket issue. Hopefully your issue is resolved , feel free to open a new ticket if you face any issues related to the runner images.

aramprice added a commit to cloudfoundry/bosh-backup-and-restore that referenced this issue Sep 4, 2024
aramprice added a commit to cloudfoundry/bosh-backup-and-restore that referenced this issue Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants
@shawaj @quesurifn @ijunaidm @vidyasagarnimmagaddi and others