-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker-compose not actually installed #10451
Comments
Hi @shawaj , We will be analysing the issue and revert with our analysis.thanks |
@shawaj - As of now Docker-compose v1 version is completely deprecated from all the images, you have to use docker-compose v2 version . |
This is an absurd change. Remove it from new images sure but existing ones shouldn't have regressions like this. As an alternative, I don't see any reason why docker-compose command can't be linked to the new command docker compose. You are just breaking people's actions for no good reason. |
I agree with @shawaj. This really affected many teams that were not using the new docker API. It broke without much warning and suddenly. This is generally what engineering teams try to avoid. |
💯 This was not communicated in any effective way to people that use this daily |
@shawaj Are you guys experiencing the added pleasure of debugging docker compose DNS issues? All of our docker compose network settings suddenly broke. We fixed with static IP two weeks ago and this morning PRs were put up and the runner failed again with the static IP fix. |
Not something we use TBH. But I feel for you because that sounds like a massive pain! I get that stuff has to be updated but it should be properly communicated. The first time you hear about it shouldn't be when your actions fail. Doesn't matter if it's a free service or not... Cloudflare is the best I've experienced in this kind of thing... Very good communication and updates |
@ijunaidm Again, I agree with @shawaj. There needs to be a banner on Github announcing such a breaking change. Otherwise the proper way to handle in the scope of the development team was to retag the image and document the change in the new runner tag so people's CI/CD doesn't break overnight and people can migrate at will instead of waking up to a fire drill. I have not met one engineering team that periodically went though the Github issues for all of their likely thousands of dependencies just to keep up to date on the latest breaking changes. That kind of flies in the face of semantic versioning and image tagging and such. How this was handled was not a best practice by any measure. Please do better! |
Sure @quesurifn. Thank you @shawaj @quesurifn . I am closing this ticket issue. |
So you are not going to fix this regression? Is that correct? |
@shawaj - Did replacing docker-compose with docker composr worked for you ? |
@shawaj - Thank you , I am closing this ticket issue. Hopefully your issue is resolved , feel free to open a new ticket if you face any issues related to the runner images. |
Description
This image says it has docker compose installed. https://github.com/actions/runner-images/blob/ubuntu22/20240811.1/images/ubuntu/Ubuntu2204-Readme.md
However it actually doesn't, as when I try to run
docker-compose config -q
it gives me an error...If I run
sudo apt-get install docker-compose
at the beginning of the action then the action completes fine but if not then it fails.This is a regression because it used to work fine until last couple of weeks.
Platforms affected
Runner images affected
Image version and build link
Version: 20240811.1.0
Is it regression?
Yes
Expected behavior
Docker compose should work
Actual behavior
Docker compose not found
Repro steps
Described above
The text was updated successfully, but these errors were encountered: