Improved Error message for missing config file (#475)

* error message for missing config * chore: formatting and index js * chore: update json5 * changes from cr Co-authored-by: AndreiLobanovich <[email protected]> * chore: recreate dist.js * chore: revert package-lock * chore: newline fix --------- Co-authored-by: AndreiLobanovich <[email protected]>
actions · Jun 30, 2023 · e3c0d9b · e3c0d9b
1 parent 0967ca8
commit e3c0d9b
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 6 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,3 +1,4 @@
 .DS_Store
 node_modules/
-lib/
+lib/
+.idea
diff --git a/dist/index.js b/dist/index.js
@@ -138,7 +138,16 @@ function getChangedFiles(client, prNumber) {
 }
 function getLabelGlobs(client, configurationPath) {
     return __awaiter(this, void 0, void 0, function* () {
-        const configurationContent = yield fetchContent(client, configurationPath);
+        let configurationContent;
+        try {
+            configurationContent = yield fetchContent(client, configurationPath);
+        }
+        catch (e) {
+            if (e.name == 'HttpError' || e.name == 'NotFound') {
+                core.warning(`The config file was not found at ${configurationPath}. Make sure it exists and that this action has the correct access rights.`);
+            }
+            throw e;
+        }
         // loads (hopefully) a `{[label:string]: string | StringOrMatchConfig[]}`, but is `any`:
         const configObject = yaml.load(configurationContent);
         // transform `any` => `Map<string,StringOrMatchConfig[]>` or throw if yaml is malformed:

diff --git a/src/labeler.ts b/src/labeler.ts
@@ -133,10 +133,17 @@ async function getLabelGlobs(
   client: ClientType,
   configurationPath: string
 ): Promise<Map<string, StringOrMatchConfig[]>> {
-  const configurationContent: string = await fetchContent(
-    client,
-    configurationPath
-  );
+  let configurationContent: string;
+  try {
+    configurationContent = await fetchContent(client, configurationPath);
+  } catch (e: any) {
+    if (e.name == 'HttpError' || e.name == 'NotFound') {
+      core.warning(
+        `The config file was not found at ${configurationPath}. Make sure it exists and that this action has the correct access rights.`
+      );
+    }
+    throw e;
+  }
 
   // loads (hopefully) a `{[label:string]: string | StringOrMatchConfig[]}`, but is `any`:
   const configObject: any = yaml.load(configurationContent);