Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite as a composite action to break the dependency on GHCR/Packages #82

Closed
wants to merge 59 commits into from
Closed

Rewrite as a composite action to break the dependency on GHCR/Packages #82

wants to merge 59 commits into from

Conversation

JamesMGreene
Copy link
Contributor

@JamesMGreene JamesMGreene commented Apr 13, 2023 •
edited
Loading

An experiment in rewriting this Docker action as a composite action (that uses the Docker image more manually) in order to break the dependency on GitHub Container Registry / GitHub Packages. 🤔🧪

Also found a GitHub Actions Runner bug in the process:

@JamesMGreene
Convert the action to a composite action
3a8755b
@JamesMGreene
Update the shell variable name used to avoid conflict
60e0c12
@JamesMGreene
Bash syntax fix
fa13680
@JamesMGreene
Bash stuff
cf79680
@JamesMGreene
Remove rogue end-quote
3fc4538
@JamesMGreene
Add some double quotes for safety
2c11bf3
@JamesMGreene
Debugging
6b64af5
@JamesMGreene
Remove debugging
b321bcf
@JamesMGreene
Remove env override, hard-code it instead
70c156f
@JamesMGreene
Handle printf dash processing
e699a06
@JamesMGreene
Handle GITHUB_ and ACTIONS_ env vars separately
30b6872
@JamesMGreene
Add debugging step for OpenSSL
51c67c1
@JamesMGreene
Switch SHA digest approach
de7887a
@JamesMGreene
Switch SHA digest approach
a59c1a3
@JamesMGreene
Fake a downed Packages
94787f2
@JamesMGreene
Dump env
0de56c7
@JamesMGreene
Add debugging ls data
384c23d
@JamesMGreene
Just use cd with abs paths instead of pushd
cca00ea
@JamesMGreene
Remove env and dir debugging
8fe3b93
@JamesMGreene
Add comment
deedf90
@JamesMGreene
Debugging docker run
6ccbdee
@JamesMGreene
List files of mounted directory within Docker
5803345
@JamesMGreene
Nicer ls output for debugging
be5b825
@JamesMGreene
Debug diff in expression vs env vars
baf8675
@JamesMGreene
Use tree instead of ls for recursive structure
eaa2eff
@JamesMGreene
More debugging
ccbf6e7
@JamesMGreene
Tree is not installed
3e885c0
@JamesMGreene
Exclude .git directory from output
c65cddc
@JamesMGreene
Sort the debugging output
829866b
@JamesMGreene
More targeted debugging
8bbb402
JamesMGreene
JamesMGreene commented Apr 14, 2023
View reviewed changes
action.yml Outdated Show resolved Hide resolved
JamesMGreene
JamesMGreene commented Apr 14, 2023
View reviewed changes
action.yml Outdated Show resolved Hide resolved
yoannchaudet
yoannchaudet reviewed Apr 14, 2023
View reviewed changes
action.yml Outdated Show resolved Hide resolved
@JamesMGreene JamesMGreene marked this pull request as ready for review April 20, 2023 04:20
@JamesMGreene JamesMGreene requested a review from a team as a code owner April 20, 2023 04:20
@JamesMGreene
Copy link
Contributor Author

Going to close this out for now as we aren't positive this will end up gaining us much given a changed internal focus on Packages. 🤔 📦

FWIW, though, if we want to come back to this in the future: this PR has been tested and verified. 🧪 ✅

@JamesMGreene JamesMGreene mentioned this pull request Jun 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoannchaudet yoannchaudet yoannchaudet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesMGreene @yoannchaudet