Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and reformat #51

Merged
merged 6 commits into from
Nov 7, 2023
Merged

Update and reformat #51

merged 6 commits into from
Nov 7, 2023

Conversation

ncalteen
Copy link
Collaborator

@ncalteen ncalteen commented Sep 15, 2023 •
edited
Loading

This PR updates and reformats this example action to align with the updates in actions/javascript-action.

  • Add linting with super-linter
  • Add formatting with Prettier
  • Switch to using @vercel/ncc to bundle dependencies (instead of committing node_modules to the repository
  • Add workflow to check dist/ directory
  • Add example CI workflow
  • Add example workflow to call this action via workflow_dispatch
  • Switch from licensed to @vercel/ncc for bundling licenses
  • Add a .gitignore
  • Add CODEOWNERS
  • Update README with example usage
  • Add unit tests
  • Add coverage/CI badges to README
  • Update package.json with various testing/formatting script options

Fixes #5
Fixes #48
Fixes #30
Fixes #12
Fixes #27
Fixes #31

@ncalteen ncalteen self-assigned this Nov 7, 2023
@ncalteen ncalteen mentioned this pull request Nov 7, 2023
Closed
sethrylan
sethrylan approved these changes Nov 7, 2023
View reviewed changes
Copy link

@sethrylan sethrylan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ncalteen ncalteen merged commit 2d874f3 into actions:main Nov 7, 2023
6 checks passed
@andyduong1920 andyduong1920 mentioned this pull request Dec 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmjoseph vmjoseph vmjoseph approved these changes

@sethrylan sethrylan sethrylan approved these changes

Assignees

@ncalteen ncalteen

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ncalteen @sethrylan @vmjoseph