-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: getRefs function to handle merge_group events #766
Conversation
👋 @elireisman, sorry for the poke; I was hoping to get a review on this 😶. I think it's a quick win ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM - and sorry I didn't see this alt. PR sooner, I think I last interacted on the other that was closed out?
I'll also ping our new FR for a second pair of 👀 before we land it cc @pcarlisle
Thanks again for the contribution! ❤️
Thanks 🙌 |
👋 I think you need to update the PR one more time prior to re-review (see the |
My bad! I missed the |
Hi @elireisman do you know another possible reviewer than @pcarlisle? |
👋 @nachtgold @louis-bompart apologies - looks like there wasn't time for anyone to circle back to this yet. Looks like we need one more dist update ( |
Fixes #456
Essentially, put #456 (comment) in the code.
To the best of my knowledge, this should work, because a
merge_group
event is a PullRequestEvent I think.