Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revise adr to support ssh #156

Merged
merged 1 commit into from
Feb 25, 2020
Merged

revise adr to support ssh #156

merged 1 commit into from
Feb 25, 2020

Conversation

ericsciple
Copy link
Contributor

@ericsciple ericsciple commented Feb 13, 2020

Proposing adding SSH support. This will help for users scripting submodule checkout.

Will open a separate ADR for a first-class submodule input.

adrs/0153-checkout-v2.md Outdated Show resolved Hide resolved
@peaceiris
Copy link

Does this proposal mean that we can also do git push with the SSH key? If yes, we can solve this problem: (Github action not triggering gh-pages upon push - GitHub Community Forum) without setting up a personal access token or SSH key by ourself.

Now, the GitHub Pages Actions provides the SSH key input option to avoid the problem. It is useful that the setting up SSH key is supported by actions/checkout.

Thank you.

@ericsciple
Copy link
Contributor Author

@peaceiris yes the ssh key will be persisted so you can script authenticated git commands. Will be removed at the end of the job.

@ericsciple ericsciple force-pushed the users/ericsciple/m166ssh branch from 8d97a3b to 2db4320 Compare February 19, 2020 17:55
@ericsciple
Copy link
Contributor Author

reviewed offline w/ @thechrisjohnson

@ericsciple ericsciple merged commit 096e927 into master Feb 25, 2020
@ericsciple ericsciple deleted the users/ericsciple/m166ssh branch February 25, 2020 15:00
@ericsciple ericsciple mentioned this pull request Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants