Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init attest sbom #3

Merged
merged 12 commits into from
Feb 23, 2024
Merged

init attest sbom #3

merged 12 commits into from
Feb 23, 2024

Conversation

ejahnGithub
Copy link
Contributor

Move the attest code from https://github.com/github/attestation-action

TODOs:

  • packages/attest will be replaced after we have npm package for packages/attest
  • add unit test

also, need to wait for this PR get merged: actions/attest#4

@ejahnGithub ejahnGithub requested a review from bdehamer February 22, 2024 17:09
Copy link
Collaborator

@bdehamer bdehamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small clean-up items, but looks good otherwise

package.json Outdated
Comment on lines 88 to 91
},
"workspaces": [
"./packages/*"
]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can ditch this

tsconfig.json Outdated
Comment on lines 18 to 19
"exclude": ["./dist", "./node_modules", "./__tests__", "./coverage"]
}
"include": [ "/src/**/*" ]
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can revert this back to the default now that we don't have the /packages directory to deal with

@ejahnGithub ejahnGithub requested a review from bdehamer February 23, 2024 23:12
Copy link
Collaborator

@bdehamer bdehamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ejahnGithub ejahnGithub merged commit 2580b8b into main Feb 23, 2024
17 checks passed
@ejahnGithub ejahnGithub deleted the eugene/attest-sbom branch February 23, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants