Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Use StatefulSet to run multiple runners #4

Closed
wants to merge 15 commits into from
Closed

Conversation

summerwind
Copy link
Contributor

No description provided.

// RunnerSpec defines the desired state of Runner
type RunnerSpec struct {
// +kubebuilder:validation:MinLength=3
// +kubebuilder:validation:Pattern=`^[^/]+/[^/]+$`
Repository string `json:"repository"`

// +optional
Image string `json:"image"`
Replicas *int32 `json:"replicas,omitempty"`
Copy link
Collaborator

@mumoshu mumoshu Mar 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use RunnerSet or something similar for managing stateful sets instead of pods?
Doing so will allow me to deploy both pod-based and stateful-set-based runners for comparison against real workloads.

// If that makes sense, I'll rename the current RunnnerSet that I've added in #1 to RunnerReplicaSet to not collide and make mine look like a less recommended way.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just submitted #6 for the rename

Copy link
Contributor Author

@summerwind summerwind Mar 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your helpful comment and PR!
Using the RunnerSet resource for StatefulSet based management is a great idea. I'm going to merge #6 after reviewing.

mumoshu added a commit to mumoshu/actions-runner-controller that referenced this pull request Mar 10, 2020
To hand over the name `RunnerSet` to the new StatefulSet-based implementation of that being developed at actions#4
mumoshu pushed a commit that referenced this pull request Jan 24, 2021
* Add chart workflows (#1)

* Add chart workflows

* Fix publishing step in CI

Signed-off-by: David Young <davidy@funkypenguin.co.nz>

* Update CI on push-to-master (#3)

* Put helm installation step in the correct CI job

Signed-off-by: David Young <davidy@funkypenguin.co.nz>

* Put helm installation step in the correct CI job (#4)

* Update on-push-master-publish-chart.yml

* Remove references to certmanager dependency

Signed-off-by: David Young <davidy@funkypenguin.co.nz>

* Add ability to customize kube-rbac-proxy image

Signed-off-by: David Young <davidy@funkypenguin.co.nz>

* Only install cert-manager if we're going to spin up KinD

Signed-off-by: David Young <davidy@funkypenguin.co.nz>
@stale
Copy link

stale bot commented Apr 30, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 30, 2021
@callum-tait-pbx
Copy link
Contributor

callum-tait-pbx commented May 2, 2021

@mumoshu PRs are included by the stale bot at the moment, if any are they are going to hang around they need one of the exempt labels. Alternatively you can reconfigure the stale config to monitor issues only if you prefer, whatever you think is best 🤷

@stale stale bot removed the stale label May 2, 2021
@toast-gear
Copy link
Collaborator

Let me close this due to inactivity and conflicts, but feel free to restart another pull request. Thanks anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants