Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix readme doc for The helm command for webhook installation #1188

Merged
merged 2 commits into from
Mar 8, 2022
Merged

fix readme doc for The helm command for webhook installation #1188

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c565815
fix doc for install the webhook server
yourmoonlight Mar 7, 2022
d001a6b
modify cmd with single set && add double quote for zsh users
yourmoonlight Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,9 +581,9 @@ To enable this feature, you firstly need to install the webhook server, currentl
_[see the values documentation for all configuration options](https://github.com/actions-runner-controller/actions-runner-controller/blob/master/charts/actions-runner-controller/README.md)_

```console
$ helm --upgrade install actions-runner-controller/actions-runner-controller \
githubWebhookServer.enabled=true \
githubWebhookServer.ports[0].nodePort=33080
$ helm upgrade --install --namespace actions-runner-system --create-namespace \
--wait actions-runner-controller actions-runner-controller/actions-runner-controller \
--set "githubWebhookServer.enabled=true,githubWebhookServer.ports[0].nodePort=33080"
```

The above command will result in exposing the node port 33080 for Webhook events. Usually, you need to create an
Expand Down