Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deprecated APIs #144

Closed
Hi-Fi opened this issue Oct 26, 2020 · 6 comments · Fixed by #733
Closed

Update deprecated APIs #144

Hi-Fi opened this issue Oct 26, 2020 · 6 comments · Fixed by #733
Labels
chore

Comments

@Hi-Fi
Copy link
Contributor

Hi-Fi commented Oct 26, 2020

  • Warning: apiextensions.k8s.io/v1beta1 CustomResourceDefinition is deprecated in v1.16+, unavailable in v1.22+; use apiextensions.k8s.io/v1 CustomResourceDefinition
  • Warning: admissionregistration.k8s.io/v1beta1 MutatingWebhookConfiguration is deprecated in v1.16+, unavailable in v1.22+; use admissionregistration.k8s.io/v1 MutatingWebhookConfiguration
  • Warning: admissionregistration.k8s.io/v1beta1 ValidatingWebhookConfiguration is deprecated in v1.16+, unavailable in v1.22+; use admissionregistration.k8s.io/v1 ValidatingWebhookConfiguration

At least CRD requires also fixing of tests and the default value handling of protocol.
@callum-tait-pbx callum-tait-pbx mentioned this issue Nov 16, 2020
Closed
@callum-tait-pbx callum-tait-pbx mentioned this issue Feb 7, 2021
Merged
@stale
Copy link

stale bot commented Apr 30, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 30, 2021
@callum-tait-pbx callum-tait-pbx mentioned this issue Apr 30, 2021
Merged
@callum-tait-pbx
Copy link
Contributor

@mumoshu please add the chore label to this issue to prevent the bot killing it. This will certainly need doing or the solution will stop working on modern k8s instances

@stale stale bot removed the stale label May 2, 2021
@mumoshu mumoshu added the chore label May 2, 2021
@jwalters-gpsw
Copy link

Any chance of updating admissionregistration.k8s.io/v1beta1 in the charts? We are getting "build" failures on lint.

@mumoshu
Copy link
Collaborator

mumoshu commented Jun 23, 2021

@jwalters-gpsw Hey! Thanks for reporting. As I have other high-priority items now, would you mind submitting a PR for that? I thought we've already migrated to newer controller-runtime and controller-gen in #629 and upgraded admissionregistration API used in the kustomize config. Perhaps you can make similar manual changes in the chart.

@mumoshu
Copy link
Collaborator

mumoshu commented Jun 23, 2021

Also note that CRDs have already been upgraded to the v1 API in #629

@mumoshu
Copy link
Collaborator

mumoshu commented Jun 23, 2021

I thought we've already migrated to newer controller-runtime and controller-gen in #629

Apparently, we only migrated to the newer API for newly generated resources. There are still a few remaining resources to be upgraded. You can try removing webhookVersions=v1beta1 annotations in webhook-related types in our go code and run make manifests to regenerate.

mumoshu added a commit that referenced this issue Aug 19, 2021
@mumoshu
Use non-deprecated API versions in CRDs and Webhooks
101517a 
Resolves #144
@mumoshu mumoshu mentioned this issue Aug 19, 2021
Merged
mumoshu added a commit that referenced this issue Aug 24, 2021
@mumoshu
Use non-deprecated API versions in CRDs and Webhooks (#733)
167c5b4 
Resolves #144
mumoshu added a commit that referenced this issue Aug 25, 2021
@mumoshu
chart: Fix webhook config installation error
34d9c6d 
This fixes the below error on installing the chart:

```
Error: UPGRADE FAILED: error validating "": error validating data: [ValidationError(MutatingWebhookConfiguration.webhooks[0]): missing required field "admissionReviewVersions" in io.k8s.api.admissionregistration.v1.MutatingWebhook, ValidationError(MutatingWebhookConfiguration.webhooks[1]): missing required field "admissionReviewVersions" in io.k8s.api.admissionregistration.v1.MutatingWebhook, ValidationError(MutatingWebhookConfiguration.webhooks[2]): missing required field "admissionReviewVersions" in io.k8s.api.admissionregistration.v1.MutatingWebhook, ValidationError(MutatingWebhookConfiguration.webhooks[3]): missing required field "admissionReviewVersions" in io.k8s.api.admissionregistration.v1.MutatingWebhook]
```

Ref #144
mumoshu added a commit that referenced this issue Aug 25, 2021
@mumoshu
kustomize: Fix error while generating release manifests
424c33b 
This fixes the below error that occurs in `make release`:

```
kustomize build config/default > release/actions-runner-controller.yaml
Error: accumulating resources: accumulation err='accumulating resources from '../webhook': '/home/mumoshu/p/actions-runner-controller/config/webhook' must resolve to a file': recursed accumulation of path '/home/mumoshu/p/actions-runner-controller/config/webhook': accumulating resources: accumulation err='accumulating resources from 'manifests.v1beta1.yaml': evalsymlink failure on '/home/mumoshu/p/actions-runner-controller/config/webhook/manifests.v1beta1.yaml' : lstat /home/mumoshu/p/actions-runner-controller/config/webhook/manifests.v1beta1.yaml: no such file or directory': evalsymlink failure on '/home/mumoshu/p/actions-runner-controller/config/webhook/manifests.v1beta1.yaml' : lstat /home/mumoshu/p/actions-runner-controller/config/webhook/manifests.v1beta1.yaml: no such file or directory
make: *** [Makefile:156: release] Error 1
```

Ref #144
@mumoshu mumoshu mentioned this issue Aug 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use non-deprecated API versions in CRDs and Webhooks actions/actions-runner-controller
4 participants
@mumoshu @Hi-Fi @jwalters-gpsw @callum-tait-pbx