Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type of dnsConfig added in #764 wrong #1224

Closed
jstewart612 opened this issue Mar 15, 2022 · 1 comment · Fixed by #1227
Closed

Type of dnsConfig added in #764 wrong #1224

jstewart612 opened this issue Mar 15, 2022 · 1 comment · Fixed by #1227
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
v0.23.0

Comments

@jstewart612
Copy link
Contributor

It is set to "array" when it should be set to "object". This makes it unusable and creates validation errors when specifying dnsConfig in normal PodSpec format using a map as normal. Please correct.
@jstewart612
Copy link
Contributor Author

https://github.com/actions-runner-controller/actions-runner-controller/blob/master/charts/actions-runner-controller/crds/actions.summerwind.dev_runnerdeployments.yaml#L1383 should be "object"

@toast-gear toast-gear added bug Something isn't working good first issue Good for newcomers labels Mar 15, 2022
billimek added a commit to homedepot/actions-runner-controller that referenced this issue Mar 15, 2022
@billimek
fix CRD references to dnsConfig
ebd644c 
Fixes actions#1224

Signed-off-by: GitHub <[email protected]>
@billimek billimek mentioned this issue Mar 15, 2022
Merged
@toast-gear toast-gear added this to the v0.23.0 milestone Apr 12, 2022
mumoshu pushed a commit that referenced this issue Apr 20, 2022
@billimek
Fix runner pod dnsConfig (#1227)
13bfa2d 
Fixes #1226
Fixes #1224

Signed-off-by: Jeff Billimek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging a pull request may close this issue.

Fix runner pod dnsConfig homedepot/actions-runner-controller
2 participants
@toast-gear @jstewart612