Added support to enable and disable enableServiceLinks. (#628)

This option expose internally some `KUBERNETES_*` environment variables that doesn't allow the runner to use KinD (Kubernetes in Docker) since it will try to connect to the Kubernetes cluster where the runner it's running. This option it's set by default to `true` in any Kubernetes deployment. Signed-off-by: Jonathan Gonzalez V <[email protected]>
actions · Jun 22, 2021 · a277489 · a277489
1 parent 1084a37
commit a277489
Show file tree

Hide file tree

Showing 9 changed files with 21 additions and 0 deletions.
diff --git a/api/v1alpha1/runner_types.go b/api/v1alpha1/runner_types.go
@@ -100,6 +100,9 @@ type RunnerPodSpec struct {
 	// +optional
 	Volumes []corev1.Volume `json:"volumes,omitempty"`
 
+	// +optional
+	EnableServiceLinks *bool `json:"enableServiceLinks,omitempty"`
+
 	// +optional
 	InitContainers []corev1.Container `json:"initContainers,omitempty"`
 

diff --git a/api/v1alpha1/zz_generated.deepcopy.go b/api/v1alpha1/zz_generated.deepcopy.go
diff --git a/charts/actions-runner-controller/crds/actions.summerwind.dev_runnerdeployments.yaml b/charts/actions-runner-controller/crds/actions.summerwind.dev_runnerdeployments.yaml
@@ -632,6 +632,8 @@ spec:
                           type: object
                         dockerdWithinRunnerContainer:
                           type: boolean
+                        enableServiceLinks:
+                          type: boolean
                         enterprise:
                           pattern: ^[^/]+$
                           type: string

diff --git a/charts/actions-runner-controller/crds/actions.summerwind.dev_runnerreplicasets.yaml b/charts/actions-runner-controller/crds/actions.summerwind.dev_runnerreplicasets.yaml
@@ -629,6 +629,8 @@ spec:
                           type: object
                         dockerdWithinRunnerContainer:
                           type: boolean
+                        enableServiceLinks:
+                          type: boolean
                         enterprise:
                           pattern: ^[^/]+$
                           type: string

diff --git a/charts/actions-runner-controller/crds/actions.summerwind.dev_runners.yaml b/charts/actions-runner-controller/crds/actions.summerwind.dev_runners.yaml
@@ -577,6 +577,8 @@ spec:
                   type: object
                 dockerdWithinRunnerContainer:
                   type: boolean
+                enableServiceLinks:
+                  type: boolean
                 enterprise:
                   pattern: ^[^/]+$
                   type: string

diff --git a/config/crd/bases/actions.summerwind.dev_runnerdeployments.yaml b/config/crd/bases/actions.summerwind.dev_runnerdeployments.yaml
@@ -632,6 +632,8 @@ spec:
                           type: object
                         dockerdWithinRunnerContainer:
                           type: boolean
+                        enableServiceLinks:
+                          type: boolean
                         enterprise:
                           pattern: ^[^/]+$
                           type: string

diff --git a/config/crd/bases/actions.summerwind.dev_runnerreplicasets.yaml b/config/crd/bases/actions.summerwind.dev_runnerreplicasets.yaml
@@ -629,6 +629,8 @@ spec:
                           type: object
                         dockerdWithinRunnerContainer:
                           type: boolean
+                        enableServiceLinks:
+                          type: boolean
                         enterprise:
                           pattern: ^[^/]+$
                           type: string

diff --git a/config/crd/bases/actions.summerwind.dev_runners.yaml b/config/crd/bases/actions.summerwind.dev_runners.yaml
@@ -577,6 +577,8 @@ spec:
                   type: object
                 dockerdWithinRunnerContainer:
                   type: boolean
+                enableServiceLinks:
+                  type: boolean
                 enterprise:
                   pattern: ^[^/]+$
                   type: string

diff --git a/controllers/runner_controller.go b/controllers/runner_controller.go
@@ -622,6 +622,7 @@ func (r *RunnerReconciler) newPod(runner v1alpha1.Runner) (corev1.Pod, error) {
 	}
 
 	template.Spec.SecurityContext = runner.Spec.SecurityContext
+	template.Spec.EnableServiceLinks = runner.Spec.EnableServiceLinks
 
 	registrationOnly := metav1.HasAnnotation(runner.ObjectMeta, annotationKeyRegistrationOnly)
-Original file line number
+Diff line change
@@ Expand Up @@
     	}
     	template.Spec.SecurityContext = runner.Spec.SecurityContext
+    	template.Spec.EnableServiceLinks = runner.Spec.EnableServiceLinks
     	registrationOnly := metav1.HasAnnotation(runner.ObjectMeta, annotationKeyRegistrationOnly)
@@ Expand Down @@