Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raster management #5

Merged
merged 12 commits into from
Jun 15, 2022
Merged

Raster management #5

merged 12 commits into from
Jun 15, 2022

Conversation

anikaweinmann
Copy link
Member

@anikaweinmann anikaweinmann commented Jun 13, 2022 •
edited
Loading

Basic Raster management added:

  • /locations/{location_name}/mapsets/{mapset_name}/raster_layers - GET
  • /locations/{location_name}/mapsets/{mapset_name}/raster_layers/{raster_name} - GET, DELETE, POST

@anikaweinmann anikaweinmann marked this pull request as ready for review June 14, 2022 07:59
@marcjansen marcjansen changed the title Raster managemenet Raster management Jun 14, 2022
marcjansen
marcjansen approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@marcjansen marcjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make test passes for me, while make devtest doesn't. Overall, this looks good to me.

Makefile Show resolved Hide resolved
actinia/raster.py Outdated Show resolved Hide resolved
actinia/raster.py Outdated Show resolved Hide resolved
actinia/raster.py Outdated Show resolved Hide resolved
actinia/raster.py Outdated Show resolved Hide resolved
actinia/utils.py Show resolved Hide resolved
tests/mock/actinia_raster_management_mock.py Outdated Show resolved Hide resolved
tests/test_actinia_raster_management.py Outdated Show resolved Hide resolved
tests/test_actinia_raster_management.py Outdated Show resolved Hide resolved
tests/mock/actinia_raster_management_mock.py Outdated Show resolved Hide resolved
marcjansen
marcjansen approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@marcjansen marcjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 more tiny typos, otherwise great. Thanks and this is ready to be merged from my point of view.

actinia/raster.py Outdated Show resolved Hide resolved
actinia/utils.py Outdated Show resolved Hide resolved
@anikaweinmann anikaweinmann merged commit dca61d4 into main Jun 15, 2022
@marcjansen marcjansen deleted the raster_managemenet branch June 15, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcjansen marcjansen marcjansen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anikaweinmann @marcjansen