Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cancel/termination operation for redis version >= 3.0.0 #83

Merged

Conversation

anikaweinmann
Copy link
Member

@anikaweinmann anikaweinmann commented Mar 2, 2020

There are some changes in redis (https://github.com/andymccurdy/redis-py/blob/master/CHANGES) so that the cancel operation does not work for redis>=2.10.6 (and rq>=0.10.0).
This is caused by the change in 3.0.0: Only bytes, strings and numbers (ints, longs and floats) are acceptablefor keys and values. Previously redis-py attempted to cast other types
to str() and store the result. This caused must confusion and frustration
when passing boolean values (cast to 'True' and 'False') or None values
(cast to 'None'). It is now the user's responsibility to cast all
key names and values to bytes, strings or numbers before passing the
value to redis-py.

@anikaweinmann anikaweinmann requested review from mmacata and neteler March 2, 2020 14:29
@anikaweinmann anikaweinmann added the bug Something isn't working label Mar 2, 2020
@mmacata
Copy link
Member

mmacata commented Mar 5, 2020

Cool, thank you, please merge!

@anikaweinmann anikaweinmann merged commit 3b7d9b2 into actinia-org:master Mar 5, 2020
@anikaweinmann anikaweinmann deleted the fix_cancel_opteration branch March 10, 2021 09:34
@mmacata mmacata added this to the 0.99.X milestone Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants