Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed GRASS GIS locations to projects #565

Merged
merged 31 commits into from
Dec 4, 2024
Merged

Renamed GRASS GIS locations to projects #565

merged 31 commits into from
Dec 4, 2024

Conversation

anikaweinmann
Copy link
Member

@anikaweinmann anikaweinmann commented Oct 16, 2024 •
edited
Loading

Renamed GRASS GIS locations to projects from GRASS GIS version 8.4:

  • add decorator for deprecated locations
  • add endpoints for all projects-endpoint-urls
  • Add tests for G8.3 and G8.4

mmacata
mmacata reviewed Nov 14, 2024
View reviewed changes
tests/test_noauth.py Outdated Show resolved Hide resolved
mmacata
mmacata reviewed Nov 14, 2024
View reviewed changes
tests/test_webhook.py Outdated Show resolved Hide resolved
mmacata
mmacata reviewed Nov 14, 2024
View reviewed changes
tests/test_webhook.py Outdated Show resolved Hide resolved
@anikaweinmann anikaweinmann mentioned this pull request Nov 20, 2024
Merged
@ninsbl ninsbl mentioned this pull request Nov 21, 2024
Open
@anikaweinmann anikaweinmann mentioned this pull request Nov 21, 2024
Merged
mmacata
mmacata reviewed Dec 4, 2024
View reviewed changes
src/actinia_core/endpoints.py Outdated
def get_endpoint_class_name(endpoint_class, projects_url_part="projects"):
endpoint_class_name = endpoint_class.__name__.lower()
if "project" in endpoint_class_name:
name = endpoint_class_name.replace("project", projects_url_part[:-1])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this replace "project" with "project"? Why is this needed?

mmacata
mmacata approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@mmacata mmacata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@anikaweinmann anikaweinmann merged commit a883c2e into main Dec 4, 2024
23 of 25 checks passed
@anikaweinmann anikaweinmann added this to the 5.0.0 milestone Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmacata mmacata mmacata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anikaweinmann @mmacata