Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start to cleanup tests #497

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

mmacata
Copy link
Member

@mmacata mmacata commented Dec 11, 2023

Some cleanup / simplification of tests was done in this PR:

  • Remove duplicate things out of Dockerfiles and reorder stages for better use of cache
    • remove explicit installation of actinia-api and other requirements as it is done via actinia-core installation
  • remove usage of ACTINIA_CUSTOM_TEST_CFG - test config can be used as normal config
  • start removing overwrites of config in tests
  • remove unused test file
  • remove redis config - this is used e.g. here but the call of the main method is not used in our testing setup currently. But I don't see any necessary config option written there so I see no problem in testing that way in the future without that file
  • leave a TODO in test_resource_base - handle it in a follow up PR when to decide how to handle ACTINIA_SERVER_TEST

@mmacata mmacata added the refactoring refactoring label Dec 11, 2023
@mmacata mmacata added this to the next_minor milestone Dec 11, 2023
@mmacata mmacata marked this pull request as ready for review December 12, 2023 08:52
@mmacata mmacata merged commit c27c263 into actinia-org:main Dec 13, 2023
4 checks passed
@mmacata mmacata modified the milestones: next_minor, 4.13.0 Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants