Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 1.1.1 secondary requirement to marked-as-decorative rule #2224

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add 1.1.1 secondary requirement to marked-as-decorative rule #2224

wants to merge 2 commits into from

Conversation

WilcoFiers
Copy link
Member

Found while reviewing this rule.

Need for Call for Review: 1 week

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-tripp-siteimprove dan-tripp-siteimprove dan-tripp-siteimprove approved these changes

@Jym77 Jym77 Jym77 approved these changes

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WilcoFiers @Jym77 @dan-tripp-siteimprove