Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct descriptions of failed examples in valid language tag rule #2194

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

sabernhardt
Copy link
Contributor

The first two failed examples do not have a known primary language tag, and the third example could say "three-letter code."

Need for Call for Review:
This will not require a Call for Review: editorial changes (examples section)


How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@CLAassistant
Copy link

CLAassistant commented May 28, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@Jym77 Jym77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted 👍 A bit of polishing.

_rules/html-page-lang-valid-bf051a.md Outdated Show resolved Hide resolved
_rules/html-page-lang-valid-bf051a.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@giacomo-petri giacomo-petri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with @Jym77's changes.

Copy link
Member

@carlosapaduarte carlosapaduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Committing the changes proposed by @Jym77 to try to move this one forward :-)

@carlosapaduarte
Copy link
Member

Merging.
Editorial changes, no call for review required.

@carlosapaduarte carlosapaduarte merged commit 333bea2 into act-rules:develop Dec 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants