WCAG 2.2 migration #2147
Merged
WCAG 2.2 migration #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
requested review from
carlosapaduarte,
Jym77,
kengdoj and
HelenBurge
Jym77
previously requested changes
Dec 7, 2023
There was a problem hiding this comment.
Great work!
A couple of typos.
There is also the "Scrollable content can be reached with sequential focus navigation" rule which is using text from WCAG 2.1 in its examples, might as well be updated to WCAG 2.2.
I've spotted several places (more than I've noted) which link to ARIA 1.1. This should probably be taken separately anyway (#2148). (looks like this is now taken care of 😅)
_rules/document-has-landmark-with-non-repeated-content-b40fd1.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Jean-Yves Moyen <[email protected]>
Co-authored-by: Jean-Yves Moyen <[email protected]>
carlosapaduarte
approved these changes
Dec 20, 2023
WilcoFiers
force-pushed
the
wcag22-migration
branch
from
1241815 to
8ae8f1b
Compare
WilcoFiers
commented
Jan 25, 2024
Comment on lines
-32
to
-36
| - [rotate](https://www.w3.org/TR/css-transforms/#funcdef-transform-rotate) | ||
| - [rotate3d](https://www.w3.org/TR/css-transforms-2/#funcdef-rotate3d) | ||
| - [rotateZ](https://www.w3.org/TR/css-transforms-2/#funcdef-rotatez) | ||
| - [matrix](https://www.w3.org/TR/css-transforms/#funcdef-transform-matrix) | ||
| - [matrix3d](https://www.w3.org/TR/css-transforms-2/#funcdef-matrix3d) |
There was a problem hiding this comment.
This gets treated as a code block, which caused tests to fail.
HelenBurge
approved these changes
Jan 25, 2024
sujisreerama
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update all relevant references to WCAG 2.2.
Needs a couple thorough reviews, but I don't believe this needs a call for review.
See also: act-rules/act-tools#33
How to Review And Approve