Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarified and included CJK requirements in large text definition and updated rules affected by this change #2121

Merged
merged 48 commits into from
Apr 25, 2024
Merged

Clarified and included CJK requirements in large text definition and updated rules affected by this change #2121

Show file tree
Hide file tree
Changes from 42 commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
a316f03
Update large-scale-text definition to include CJK languages with diff…
giacomo-petri Sep 14, 2023
fcc0409
updated rule
giacomo-petri Sep 14, 2023
4f781a0
added unicode reference
giacomo-petri Sep 14, 2023
4456dec
polishing definition
giacomo-petri Sep 15, 2023
a60cf76
adding spaces
giacomo-petri Sep 15, 2023
54ffbd6
spaces
giacomo-petri Sep 15, 2023
39a211d
improving understandability
giacomo-petri Sep 15, 2023
5cac272
added bold for consistency
giacomo-petri Sep 15, 2023
546a5a3
polishing the definition
giacomo-petri Sep 15, 2023
3107c19
adding passed and failed examples
giacomo-petri Sep 15, 2023
c9889a7
fixes
giacomo-petri Sep 15, 2023
4aaa207
cjk
giacomo-petri Sep 15, 2023
ab17360
fixes
giacomo-petri Sep 15, 2023
00b0cca
add lang="ja" for Japanese examples in min contrast rule
giacomo-petri Sep 15, 2023
1834876
add lang="ja" for Japanese sentences in contrast enhanced
giacomo-petri Sep 15, 2023
6aaa18d
accepted Wilco suggestion with few edits
giacomo-petri Sep 18, 2023
a8d6293
Update large-scale-text.md
giacomo-petri Sep 18, 2023
61d9e74
added words to dictionary
giacomo-petri Sep 18, 2023
2724569
Update spelling-ignore.yml
giacomo-petri Sep 18, 2023
7fcae63
Update large-scale-text.md
giacomo-petri Sep 18, 2023
41aba7f
typo
giacomo-petri Sep 18, 2023
66e806c
Update spelling-ignore.yml
giacomo-petri Sep 18, 2023
9934e03
Apply suggestions from code review
giacomo-petri Sep 28, 2023
4ded309
official to unofficial
giacomo-petri Sep 28, 2023
44b691b
Update large-scale-text.md
giacomo-petri Sep 28, 2023
caaa73a
Update large-scale-text.md
giacomo-petri Sep 28, 2023
2f0e977
replaced Japanese with Chinese
giacomo-petri Sep 28, 2023
70bb0cc
replaced Japanese with Chinese example
giacomo-petri Sep 28, 2023
b9cda2d
Merge branch 'develop' into giacomo-petri-cjk-languages
Jym77 Oct 12, 2023
8b1c88a
Update __tests__/spelling-ignore.yml
WilcoFiers Oct 26, 2023
03cf3d3
Merge branch 'develop' into giacomo-petri-cjk-languages
Jym77 Nov 30, 2023
9063dba
Update spelling.js
giacomo-petri Dec 9, 2023
b412651
Merge branch 'develop' into giacomo-petri-cjk-languages
Jym77 Dec 14, 2023
33b28d6
Merge branch 'develop' into giacomo-petri-cjk-languages
Jym77 Jan 10, 2024
3f89a93
Merge branch 'develop' into giacomo-petri-cjk-languages
Jym77 Jan 11, 2024
221799d
Update pages/glossary/large-scale-text.md
giacomo-petri Jan 18, 2024
d08ce97
Merge branch 'develop' into giacomo-petri-cjk-languages
Jym77 Jan 18, 2024
3bacb00
Update large-scale-text.md
giacomo-petri Feb 7, 2024
520f01c
Update text-contrast-afw4f7.md
giacomo-petri Feb 7, 2024
7d4f76d
Update text-contrast-enhanced-09o5cg.md
giacomo-petri Feb 7, 2024
eace061
Update text-contrast-afw4f7.md
giacomo-petri Feb 7, 2024
496f0bf
Update large-scale-text.md
giacomo-petri Feb 7, 2024
2196334
Update spelling-ignore.yml
giacomo-petri Mar 4, 2024
0b622d5
Apply suggestions from code review
giacomo-petri Mar 4, 2024
e7e290f
Update large-scale-text.md
giacomo-petri Mar 4, 2024
bbf55cb
Update pages/glossary/large-scale-text.md
giacomo-petri Mar 8, 2024
eaa3902
Merge branch 'develop' into giacomo-petri-cjk-languages
Jym77 Apr 18, 2024
cf72047
Merge branch 'develop' into giacomo-petri-cjk-languages
Jym77 Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions __tests__/spelling-ignore.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,10 @@
- merchantability
- de-hello
- 14pt
- 16pt
- 18pt
WilcoFiers marked this conversation as resolved.
Show resolved Hide resolved
- 20pt
- 22pt
giacomo-petri marked this conversation as resolved.
Show resolved Hide resolved
- Helvetica
- DeviceOrientation
- fieldsets
Expand All @@ -124,6 +127,7 @@
# Notes and acronyms
- TODO
- TBD
- CJK

# Tool and library names
- axe-core
Expand Down Expand Up @@ -241,6 +245,9 @@
- 000B
- 000C
- 000D
- 4E00
giacomo-petri marked this conversation as resolved.
Show resolved Hide resolved
- 9FFF
- 4E00–9FFF

# JSON attributes/ metadata/ methods
- testcases
Expand Down
2 changes: 1 addition & 1 deletion __tests__/spelling.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ function getCuratedMarkdownBody(body, options = {}) {
* @returns {String[]}
*/
function getSpellIgnored() {
const ignoreConfigured = yaml.safeLoad(fs.readFileSync('./__tests__/spelling-ignore.yml', 'utf8'))
const ignoreConfigured = yaml.safeLoad(fs.readFileSync('./__tests__/spelling-ignore.yml', 'utf8'), {schema: yaml.FAILSAFE_SCHEMA}) //added schema due to entries starting with a non-zero digit

/*
Building spelling exception in the shape FOOxxx where xxx is a number.
Expand Down
22 changes: 19 additions & 3 deletions pages/glossary/large-scale-text.md
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rewrote a few things, including updating the links as I found this a little difficult to read with all the URLs in them:

**Exception**: If the text nodes contain Unicode characters in the 4E00–9FFF range:

- at least 22 [points][], or
- at least 18 [points][] and a [computed][] [font weight][] CSS property of 700 or higher.

**Notes:**  
The WCAG definition of [large scale text](https://www.w3.org/TR/WCAG21/#dfn-large-scale) includes an exception for CJK (Chinese, Japanese, and Korean) text. The Unicode range 4E00–9FFF includes these characters. The "equivalent size" numbers are not included in WCAG, and come from the [Official Japanese Translation of WCAG 2.1](https://waic.jp/translations/WCAG21/#dfn-large-scale).  This translation offers the following insight (translated from Japanese to English to allow everyone understanding the specs):  

> TRANSLATION NOTE  
> In the case of Japanese full-width characters, 22 point or 18 point bold type is considered to be the "equivalent" size, based on the First Report of the Enlarged Textbook Promotion Council, "Chapter 2 Standards for Enlarged Textbooks." is reasonable."
Assuming all CJK characters pose similar contrast challanges, this definition extends the Japanese requirement to the whole CJK characters set included in the [Unicode standard](https://unicode.org/charts/PDF/U4E00.pdf) within the range of 4E00–9FFF.

[computed]: https://www.w3.org/TR/css-cascade-3/#computed-value
[font-size]: https://www.w3.org/TR/css-fonts-3/#propdef-font-size
[points]: https://www.w3.org/TR/css-values/#pt
[font weight]: https://www.w3.org/TR/css-fonts-3/#font-weight-prop

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taiwan has different requirements than Japan, I propose the following:

**Exception**:  
A text node containing Unicode characters in the 4E00–9FFF range ([CJK Unified Ideographs](https://unicode.org/charts/PDF/U4E00.pdf)) is <dfn id="large-scale-text:cjk">large scale text</dfn> if at least one of the following is true:

- the Japanese text node [computed][] [font-size][] is at least 22 [points][], or
- the Traditional Chinese text node [computed][] [font-size][] is at least 20 [points][], or
- the Japanese text node [computed][] [font-size][] is at least 18 [points][] and has a [computed][] [font weight][] of 700 or higher, or
- the Traditional Chinese text node [computed][] [font-size][] is at least 16 [points][] and has a [computed][] [font weight][] of 700 or higher.

**Notes:**  
The WCAG definition of [large scale text](https://www.w3.org/TR/WCAG21/#dfn-large-scale) includes an exception for CJK (Chinese, Japanese, and Korean) fonts. The Unicode range 4E00–9FFF includes these characters. The "equivalent size" numbers are not included in WCAG, and come from the [Taiwanese Readability Reference Guidelines](https://crpd.sfaa.gov.tw/BulletinCtrl?func=downloadFile&type=file&id=3749&code=F9FEF1F8F1FAF6FAFCFAFCFCFFFAF2F3) (PDF download) and the [Unofficial Japanese Translation of WCAG 2.1](https://waic.jp/translations/WCAG21/#dfn-large-scale). The Taiwanese Readability Reference Guidelines requires minimal font size 16 points for Traditional Chinese characters and 14 points for English characters to be fulfill the need of the people with disabilities, and the Unofficial Japanese translation offers the following insight (translated from Japanese to English to allow everyone understanding the specs):

Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,23 @@ input_aspects:
- DOM tree
---

Text nodes with a [computed](https://www.w3.org/TR/css-cascade-3/#computed-value) [font-size](https://www.w3.org/TR/css-fonts-3/#propdef-font-size) of:
A text node is large scale text if at least one of the following is true:

- at least 18 [points](https://www.w3.org/TR/css-values/#pt), or
- at least 14 [points](https://www.w3.org/TR/css-values/#pt) and a [computed](https://www.w3.org/TR/css-cascade-3/#computed-value) [font weight](https://www.w3.org/TR/css-fonts-3/#font-weight-prop) CSS property of 700 or higher.
- the text node [computed][] [font-size][] is at least 18 [points][], or
- the text node [computed][] [font-size][] is at least 14 [points][] and has a [computed][] [font weight][] of 700 or higher.


**Notes:**
giacomo-petri marked this conversation as resolved.
Show resolved Hide resolved
In the domain of languages such as Chinese, Japanese, and Korean (CJK languages), encompassing the Unicode character range from 4E00 to 9FFF ([CJK Unified Ideographs](https://unicode.org/charts/PDF/U4E00.pdf)), it becomes crucial to acknowledge the intricate nuances in their typographic requirements. Despite sharing a common Unicode spectrum, each CJK language and its corresponding country may exhibit distinct typographic preferences and standards.

Particularly noteworthy is the lack of uniformity in defining text sizes as either large or small within the following ranges:
- from 18 [points][] to 22 [points][]
- from 14 [points][] to 18 [points][] with a [computed][] [font weight][] of 700 or higher.

Given the diversity in these specifications, the ACT rules adhere to the large text definition outlined above. This definition is applicable across all languages under the rationale of "no false positives."
giacomo-petri marked this conversation as resolved.
Show resolved Hide resolved


[computed]: https://www.w3.org/TR/css-cascade-3/#computed-value
[font-size]: https://www.w3.org/TR/css-fonts-3/#propdef-font-size
[points]: https://www.w3.org/TR/css-values/#pt
[font weight]: https://www.w3.org/TR/css-fonts-3/#font-weight-prop
Loading