Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix markup issue in Iframe has name rule #2116

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Fix markup issue in Iframe has name rule #2116

merged 3 commits into from
Oct 13, 2023

Conversation

WilcoFiers
Copy link
Member

Need for Call for Review: none, editorial

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@WilcoFiers WilcoFiers merged commit 5f6942e into develop Oct 13, 2023
1 check passed
@WilcoFiers WilcoFiers deleted the iframe-name-broken-link branch October 13, 2023 13:51
Jym77 pushed a commit that referenced this pull request Oct 26, 2023
@WilcoFiers @Jym77
Fix markup issue in Iframe has name rule (#2116)
01a9d63 
* Fix markup issue in Iframe has name rule

* Update _rules/iframe-non-empty-accessible-name-cae760.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colabottles colabottles colabottles approved these changes

@Jym77 Jym77 Jym77 approved these changes

@carlosapaduarte carlosapaduarte carlosapaduarte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WilcoFiers @carlosapaduarte @Jym77 @colabottles