Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop linking to proposed rules #2108

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Stop linking to proposed rules #2108

merged 3 commits into from
Oct 13, 2023

Conversation

WilcoFiers
Copy link
Member

Since we have redirects set up now, if the rule isn't approved yet, we don't need to link to proposed rules anymore.

Need for Call for Review: none, editorial stuff


How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

Copy link
Member

@carlosapaduarte carlosapaduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some trailing slashes left behind

_rules/bypass-blocks-cf77f2.md Outdated Show resolved Hide resolved
_rules/bypass-blocks-cf77f2.md Outdated Show resolved Hide resolved
_rules/bypass-blocks-cf77f2.md Outdated Show resolved Hide resolved
_rules/bypass-blocks-cf77f2.md Outdated Show resolved Hide resolved
@WilcoFiers WilcoFiers merged commit e701c3d into develop Oct 13, 2023
1 check passed
@WilcoFiers WilcoFiers deleted the no-proposed-links branch October 13, 2023 13:58
Jym77 pushed a commit that referenced this pull request Oct 26, 2023
* Stop linking to proposed rules

* Apply suggestions from code review

Co-authored-by: Carlos Duarte <[email protected]>

---------

Co-authored-by: Carlos Duarte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants