-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn "visible" examples into a rule #2087
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good
And the visible definition will also have to be edited, because it links to the examples. It should link to the new "rule" instead. |
Yes. Not sure what URL the new "rule" would have, though 😅 |
As per CG discussion, trying to turn definition's examples into a "rule" to see if we can benefit from the existing machinery to provide these in a testable way to tool implementers.
This is meant as a convenience for tool implementers, not to test any sort of requirements.
We will still need to add a bit of machinery to correctly export these test cases. We want them separated from the actual test cases of actual rules, so that testing them is purely opt-in from implementers.
Closes issue(s):
Need for Call for Review:
This will require a 2 weeks Call for Review (new process)
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.When merging a PR:
How to Review And Approve