Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 2nd WCAG reference: 1.3.1 #1747

Merged
merged 7 commits into from
Feb 10, 2022
Merged

Remove 2nd WCAG reference: 1.3.1 #1747

merged 7 commits into from
Feb 10, 2022

Conversation

HelenBurge
Copy link
Collaborator

@HelenBurge HelenBurge commented Nov 21, 2021

Remove 1.3.1 as this is more relatable to 1.3.3, being a visual rule, and trying to only use 1 WCAG SC per rule.

Removed the 1.3.1 reference

Closes issue(s):

  • N/A

Need for Call for Review:
This will require a 1 week Call for Review

Remove 1.3.1 as this is more relatable to 1.3.3, being a visual rule, and trying to only use 1 WCAG SC per rule.
colabottles
colabottles previously approved these changes Nov 22, 2021
wcreedle
wcreedle previously approved these changes Nov 23, 2021
@HelenBurge HelenBurge changed the title Update non-visual-reference-alternative-9bd38c.md Remove 2nd WCAG reference: 1.3.1 Nov 23, 2021
Copy link
Member

@carlosapaduarte carlosapaduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to take out the references to 1.3.1 from the Assumptions and Background sections

Copy link
Member

@carlosapaduarte carlosapaduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text in the Assumptions and Background sections still talks about SC 1.3.1
Worse, it even discusses a situation where 1.3.1 would fail while 1.3.3 would not. I'm pretty sure we need to adapt both sections of the rule to update the rule.

@HelenBurge
Copy link
Collaborator Author

I think before committing this change - this needs to be discussed to see if we need to do more work and/or reverse it all!

@tbostic32
Copy link
Collaborator

Given the discussion above and looking into the rule I don't have any strong feelings. Maybe a slight preference towards leaving it as is, but I agree 1.3.3 is much more applicable.

One other thought about the last sentence in the background section: "[Only 1.3.1 would fail instead of both means] the rule passes as it is not a failure of all accessibility requirements". Is that a true statement? I thought we had rules where only one of the requirements fails and so it fails the rule. I can't actually find a definitive answer for this in the rules format spec, maybe something we should clarify.

@HelenBurge
Copy link
Collaborator Author

Need to resolve all references to 1.3.1 before submitting for review.

@HelenBurge HelenBurge dismissed stale reviews from wcreedle and colabottles January 13, 2022 15:40

Rework being done

Removed references to 1.3.1 to update the rule contents for just failing 1.3.3
@HelenBurge HelenBurge dismissed carlosapaduarte’s stale review January 20, 2022 13:40

Updated as requested

readded the reference to stop failings
@@ -63,13 +58,12 @@ _There are no major accessibility support issues known for this rule._

[Visual reference words][] that can be interpreted with the non-sensory meaning include, in English, expressions like "right after this" where "right" is a [visual reference word][] used with the meaning "immediately"; or words like "below" that is often used with the meaning "further in reading order".

The rule doesn't require the non-visual characteristic description to be included in the accessibility tree. If the alternatives are not included in the accessibility tree, only [Success Criteria 1.3.1 Info and Relationships][sc131] would fail instead of both [Success Criterion 1.3.3 Sensory Characteristics][sc133] and [Success Criteria 1.3.1 Info and Relationships][sc131]. Hence, the rule passes in these cases as it is not a failure of all accessibility requirements.
The rule doesn't require the non-visual characteristic description to be included in the accessibility tree. If the alternatives are not included in the accessibility tree, only [Success Criteria 1.3.1 Info and Relationships][sc131] would fail instead of [Success Criterion 1.3.3 Sensory Characteristics][sc133]. Hence, the rule passes in these cases as it is not a failure of the accessibility requirements of this rule.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only confusion is how passed example 12 (example with description not included in the accessibility tree) was passing with 1.3.1 is/was passing to begin with. We typically don't like examples that don't pass all criteria unless they are extensions of each other (e.g., AA and AAA for color contrast). If someone could clear that up would be great, but otherwise I think this is good to go.

@HelenBurge HelenBurge added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Feb 3, 2022
@HelenBurge HelenBurge merged commit f6f7bef into develop Feb 10, 2022
@HelenBurge HelenBurge deleted the HB-Remove-2nd-SC branch February 10, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Call 1 week Call for review for small changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants