Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 1.3.1 from presentational children rule #1726

Merged
merged 3 commits into from
Oct 14, 2021
Merged

Conversation

WilcoFiers
Copy link
Member

Task force decided 1.3.1 is not appropriate for this rule.

Need for Call for Review: 1 week


How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@WilcoFiers WilcoFiers added the Review Call 1 week Call for review for small changes label Oct 1, 2021
@WilcoFiers WilcoFiers merged commit 614158d into develop Oct 14, 2021
@WilcoFiers WilcoFiers deleted the WilcoFiers-patch-1 branch October 14, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Call 1 week Call for review for small changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants