-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update line-height-not-important-78fd32.md #1683
Conversation
Removed extra "1.5" and changed failed example descriptions from using recommend -> required.
In the second part of your comment here #1686 (comment) you mentioned adding another example of using padding to create enough space to pass. I don't think we can do that without changing the expectation; as it is currently written I think it would fail the rule. Update from ACT TF meeting
|
Co-authored-by: Jean-Yves Moyen <[email protected]>
Co-authored-by: Jean-Yves Moyen <[email protected]>
Co-authored-by: Jean-Yves Moyen <[email protected]>
Looks like tests are failing because it doesn't like the word unitless (thinks its a misspelling) and the definition of |
The unused definitions can simply be removed from the definitions list at the bottom of the file (lines 307 and 315 it seems). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering whether we should have a viewport specified in the Applicability, but I guess I'd like to see what other think about that.
The rest are polishing. So I'm approving now to let other review and give their opinion on the viewport question 👍
Co-authored-by: Jean-Yves Moyen <[email protected]>
Many changes have occured since this approval was granted.
Call for review e-mail here: https://lists.w3.org/Archives/Public/public-act-r/2022Jan/0006.html We forgot to label it. Apologies. |
Removed extra "1.5" and changed failed example descriptions from using recommend -> required.
Need for Final Call:
This will require 2 week Final Call - Significant changes to the applicability, expectation, background, and some to the test cases.
How to Review And Approve