Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial changes to Graphics with no text 0va7u6 #1592

Merged
merged 4 commits into from
May 10, 2021
Merged

Conversation

ajanec01
Copy link
Collaborator

@ajanec01 ajanec01 commented May 2, 2021

Editorial changes to HTML graphics contain no text + fixing source location for a couple of examples.

No need for the final call.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Final Call period. In case of disagreement, the longer period wins.

Editorial changes to [HTML graphics contain no text](https://act-rules.github.io/rules/0va7u6#rendered-image-resource) + fixing source location for a couple of examples.

No need for the final call.
Copy link
Member

@carlosapaduarte carlosapaduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a couple of typos

_rules/image-no-text-0va7u6.md Outdated Show resolved Hide resolved
_rules/image-no-text-0va7u6.md Outdated Show resolved Hide resolved
ajanec01 and others added 2 commits May 8, 2021 23:15
@ajanec01 ajanec01 merged commit 1d8d3aa into develop May 10, 2021
@ajanec01 ajanec01 deleted the ajanec01-patch-3 branch May 10, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants