-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autocomplete="off" fails "autocomplete attribute has valid value" (73f2c2) #1540
Comments
Yeah, looks like we missed that one. I had a quick look at our own implementation, and it gets this right, but it does not seem to be covered by the rule. Would you be up for submitting a fix for this? I think another bullet in the applicability, and an inapplicable example of this would be the way to go for this. |
Is the background section not sufficient to fix this issue? I guess we could move it to applicability but that would create a rather large applicability section.
|
I think it would be best to include it in the expectation, like e.g. Siteimprove has done in their rule documentation: https://alfa.siteimprove.com/rules/sia-r10. Right now an automated checker implementing a more naive version of this rule will get a bunch of false positives for this rule. |
I will create a pull request to create expectation number 3. I'm inclined to keep the entire paragraph as is because it clearly refers to |
As I see it, this rule should check whether the autocomplete has a valid value, while another rule could be created to check whether the value is appropriate. Much like it is being done for the rules for 3.1.1 Language of Page. |
I've no objections to that. It would be good to get input from the rest of the community before we do that. @WilcoFiers and @carlosapaduarte, is it ok to put it on the agenda for the next call? |
The rule "autocomplete attribute has valid value" (73f2c2) has the assumption "The autocomplete attribute is used on form fields that correspond to Input Purposes for User Interface Components and collect information about the user."
This means that the use of autocomplete="off" is actually not applicable to the rule due to the expectation.
However, I have twice this week had to debug automated testing results (from two different checker engines) that failed autocomplete="off".
I think this is an indication that the rule incorrectly flags a common practice as an accessibility issue.
The text was updated successfully, but these errors were encountered: