Skip to content

Commit

Permalink
Merge branch 'develop' into text-spacing-rewrite
Browse files Browse the repository at this point in the history
  • Loading branch information
@Jym77
Jym77 authored Sep 28, 2023
2 parents 5ced4b4 + db69b36 commit f82a0c4
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 20 deletions.
7 changes: 3 additions & 4 deletions .github/workflows/approve-rule.yml
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Sets a rule to "approved" in the wcag-act-rules repository in a given branch.
# Sets a rule to "approved" in the wcag-act-rules repository in a given branch.
name: Set a rule to approved
on:
workflow_dispatch:
Expand All @@ -14,12 +14,11 @@ jobs:
dispatch:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Check user permission
uses: 74th/[email protected]
with:
listfile: .github/workflows/chair-accounts.md

- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '16'
Expand All @@ -39,4 +38,4 @@ jobs:
git config --global user.name "${{ secrets.WAI_GIT_NAME }}"
git config --global user.email "${{ secrets.WAI_GIT_EMAIL }}"
- name: Set rule to approved
run: npx zx .github/scripts/wai-build.mjs --ruleId ${{ github.event.inputs.ruleId }}" --branch ${{ github.event.inputs.branch }}"
run: npx zx .github/scripts/approve-rule.mjs --ruleId "${{ github.event.inputs.ruleId }}" --branch "${{ github.event.inputs.branch }}"
28 changes: 14 additions & 14 deletions _rules/element-lang-valid-de46e4.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ There are differences in how assistive technologies handle unknown and invalid l
This `article` element has a `lang` [attribute value][] which has a [known primary language tag][].

```html
<html>
<html lang="es">
<body>
<article lang="en">
They wandered into a strange Tiki bar on the edge of the small beach town.
Expand All @@ -85,7 +85,7 @@ This `article` element has a `lang` [attribute value][] which has a [known prima
This `blockquote` element has a `lang` [attribute value][] which has a [known primary language tag][]. The region section ("CH") in the value is ignored by the rule (and the definition of [known primary language tag][]).

```html
<html>
<html lang="en">
<body>
<blockquote lang="fr-CH">
Ils ont trouvé un étrange bar Tiki aux abords de la petite ville balnéaire.
Expand All @@ -99,7 +99,7 @@ This `blockquote` element has a `lang` [attribute value][] which has a [known pr
This `p` element has a `lang` [attribute value][] which has a [known primary language tag][], but a syntactically invalid region subtag which is ignored by the rule.

```html
<html>
<html lang="fr">
<body>
<p lang="en-US-GB">
They wandered into a strange Tiki bar on the edge of the small beach town.
Expand All @@ -113,7 +113,7 @@ This `p` element has a `lang` [attribute value][] which has a [known primary lan
This `div` element has a valid `lang` [attribute value][]. There is no [text inheriting its programmatic language][] from the `article` element, therefore its `lang` attribute is not considered by the rule.

```html
<html>
<html lang="fr">
<body>
<article lang="invalid">
<div lang="en">
Expand All @@ -129,7 +129,7 @@ This `div` element has a valid `lang` [attribute value][]. There is no [text inh
This `div` element has a valid `lang` [attribute value][]. The [accessible name][] of the image is [text inheriting its programmatic language][] from the `div` element.

```html
<html>
<html lang="es">
<body>
<div lang="EN">
<img src="/test-assets/shared/fireworks.jpg" alt="Fireworks over Paris" />
Expand All @@ -145,7 +145,7 @@ This `div` element has a valid `lang` [attribute value][]. The [accessible name]
This `article` element has a `lang` [attribute value][] which does not have a [known primary language tag][] because its primary language subtag does not exist in the [language subtag registry][].

```html
<html>
<html lang="es">
<body>
<article lang="dutch">
Zij liepen een vreemde Tiki bar binnen, aan de rand van een dorpje aan het strand.
Expand All @@ -159,7 +159,7 @@ This `article` element has a `lang` [attribute value][] which does not have a [k
This `article` element has a `lang` [attribute value][] which has no [known primary language tag][].

```html
<html>
<html lang="en">
<body>
<article lang="#!">
They wandered into a strange Tiki bar on the edge of the small beach town.
Expand All @@ -173,7 +173,7 @@ This `article` element has a `lang` [attribute value][] which has no [known prim
This `article` element has a `lang` [attribute value][] which consists of only [whitespace][] and thus has no [known primary language tag][].

```html
<html>
<html lang="fr">
<body>
<article lang=" ">
They wandered into a strange Tiki bar on the edge of the small beach town.
Expand All @@ -184,10 +184,10 @@ This `article` element has a `lang` [attribute value][] which consists of only [

#### Failed Example 4

The `lang` [attribute value][] does not have a valid language tag. The `lang` attribute must be valid because the content is [visible][].
The `lang` [attribute value][] does not have a valid language tag. Even though the `p` element is not [included in the accessibility tree][] due to the presence of the `aria-hidden="true"` attribute, it is [visible][]; therefore its content is [text inheriting its programmatic language][] from the `article` element. Hence, the lang attribute must be valid.

```html
<html>
<html lang="es">
<body>
<article lang="english">
<p aria-hidden="true">
Expand All @@ -200,10 +200,10 @@ The `lang` [attribute value][] does not have a valid language tag. The `lang` at

#### Failed Example 5

The `lang` [attribute value][] does not have a valid language tag, and its [descendant][] is not [visible][] though it is still [included in the accessibility tree][].
The `lang` [attribute value][] does not have a valid language tag. Even though the `p` element is not [visible][] due to it being moved off-screen, it is [included in the accessibility tree][]; therefore its content is [text inheriting its programmatic language][] from the `article` element. Hence, the lang attribute must be valid.

```html
<html>
<html lang="fr">
<body>
<article lang="English">
<p style="position: absolute; top: -9999px">
Expand All @@ -219,7 +219,7 @@ The `lang` [attribute value][] does not have a valid language tag, and its [desc
This `div` element has an invalid `lang` [attribute value][]. There is no [text inheriting its programmatic language][] from the `article` element, therefore its `lang` attribute is not considered by the rule.

```html
<html>
<html lang="es">
<body>
<article lang="en">
<div lang="invalid">
Expand All @@ -235,7 +235,7 @@ This `div` element has an invalid `lang` [attribute value][]. There is no [text
This `div` element has an invalid `lang` [attribute value][]. The [accessible name][] of the image is [text inheriting its programmatic language][] from the `div` element.

```html
<html>
<html lang="en">
<body>
<div lang="invalid">
<img src="/test-assets/shared/fireworks.jpg" alt="Fireworks over Paris" />
Expand Down
2 changes: 0 additions & 2 deletions _rules/menuitem-non-empty-name-m6b1q3.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ This rule assumes that all menuitems are [user interface components as defined b

## Accessibility Support

In some assistive technologies, the `menuitem` role will only be announced in browsing mode. When they receive focus this role is not announced. Additionally, the `title` attribute is not a reliable way to provide an accessible name. Use `aria-label` instead.

Implementation of [Presentational Roles Conflict Resolution][] varies from one browser or assistive technology to another. Depending on this, some [semantic][semantic role] `menuitem` elements can fail this rule with some technology but users of other technologies would not experience any accessibility issue.

## Background
Expand Down

0 comments on commit f82a0c4

Please sign in to comment.