[IMP] fastapi: Simplified code and improved perfs

The use of a BytesIO in place of our specialized SeekableStream class to keep the input stream in case we need to process the request again due to a retryable error outperforms both in terms of speed and memory consumption. see OCA#440 (comment) for more info.
acsone · Jun 28, 2024 · 1b0e0ad · 1b0e0ad
1 parent 8b82ecd
commit 1b0e0ad
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 190 deletions.
diff --git a/fastapi/fastapi_dispatcher.py b/fastapi/fastapi_dispatcher.py
@@ -16,7 +16,6 @@
 from fastapi.utils import is_body_allowed_for_status_code
 
 from .context import odoo_env_ctx
-from .seekable_stream import SeekableStream
 
 
 class FastApiDispatcher(Dispatcher):
@@ -125,7 +124,7 @@ def _get_environ(self):
             # from the stream. This way we can seek back to the beginning
             # of the stream to read the data again if needed.
             if not hasattr(httprequest, "_cached_stream"):
-                httprequest._cached_stream = SeekableStream(stream)
+                httprequest._cached_stream = BytesIO(stream.read())
             stream = httprequest._cached_stream
             stream.seek(0)
         environ["wsgi.input"] = stream

diff --git a/fastapi/seekable_stream.py b/fastapi/seekable_stream.py
diff --git a/fastapi/tests/__init__.py b/fastapi/tests/__init__.py
@@ -1,3 +1,2 @@
 from . import test_fastapi
 from . import test_fastapi_demo
-from . import test_seekable_stream
diff --git a/fastapi/tests/test_seekable_stream.py b/fastapi/tests/test_seekable_stream.py