improve: add testnet entries #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxrl
reviewed
Feb 7, 2024
src/constants.ts
Outdated
| @@ -14,6 +14,7 @@ export const CHAIN_IDs = { | |||
| OPTIMISM_GOERLI: 420, | |||
| ZK_SYNC_GOERLI: 280, | |||
| BASE_GOERLI: 84531, | |||
| BASE_SEPOLIA: 111551111, | |||
There was a problem hiding this comment.
ooc, have you tested this? 84532 is the chain ID reported by multiple sources. For example: https://docs.base.org/network-information/#base-testnet-sepolia.
fwiw I've also raised a PR on top of this one to add some extra chainIds, but it's nice to inherit the token definitions from this one: #13.
There was a problem hiding this comment.
Yep! I've pushed the most recent local changes now.
Also some slight re-ordering so that the prod networks are always first, and then that ordering is repeated for each subsequent testnet. Testnets are always grouped.
pxrl
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.