-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solve sim speed #144
Solve sim speed #144
Conversation
Updating Kubernetes DAG...Please wait until the job has finished. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @GeraldoSJr, thank you for the PR! Can you please update code changes so that instead of using a "stepwise" function, the speed is controlled by a constant factor? I.e.,
let sleep_duration = max(0, (next_ts - sim_ts) / speed_factor);
This way we're guaranteed that, with a speed factor of 2, that the simulation will run exactly twice as fast.
Added the changes requested, that was actually my innitial approach, changed midway to resolve the issue more directly, anyways, hope this will solve it now. Just wanted to say that I'm excited to start helping in the repo, really nice project! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi -- a few small changes, but this is basically there. Thanks!
Description
This PR fix the issue Run simulation at different speeds by adding a argument, sim_step_duration, to the cli and passing this argument to the run_trace function and allowing the simulation to run on this speed instead of the fixed timestamp speed specified on the trace.
Testing done
Additional info
Resolves #76