Skip to content
This repository has been archived by the owner on Nov 16, 2021. It is now read-only.

Remove hook_install() from generated subprofiles #622

Open
wants to merge 2 commits into
base: 8.x-3.x
Choose a base branch
from

Conversation

danepowell
Copy link
Contributor

Lightning doesn't have a hook_install() implementation in the base profile, I think specifically so that it will be compatible with the new D8.6 feature of installing site from existing config.

However, the subprofile template still creates a hook_install() implementation, which breaks the ability to install sites from existing config.

An example of this breaking things: acquia/blt#3241 (comment)

@phenaproxima phenaproxima changed the title Remove hook_install() from subprofile. Remove hook_install() from generated subprofiles Nov 15, 2018
@phenaproxima
Copy link
Collaborator

+1 for removing the function, but to compensate for that, let's keep the comment explaining that hook_install() should be implemented in order to do various tasks. But let's also mention that it will render the profile incompatible with config installs, and cite a change record to back that up.

@danepowell
Copy link
Contributor Author

I added the requested comments. I don't think the test failures are specific to this PR.

@balsama
Copy link
Contributor

balsama commented Dec 18, 2018

Rerunning tests. RTBC from me if they pass - which they should.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants