This repository has been archived by the owner on Nov 16, 2021. It is now read-only.
Remove hook_install() from generated subprofiles #622
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lightning doesn't have a hook_install() implementation in the base profile, I think specifically so that it will be compatible with the new D8.6 feature of installing site from existing config.
However, the subprofile template still creates a hook_install() implementation, which breaks the ability to install sites from existing config.
An example of this breaking things: acquia/blt#3241 (comment)