Skip to content
This repository has been archived by the owner on Nov 16, 2021. It is now read-only.

Add support for Drupal profiles living outside of d.o. #612

Open
wants to merge 1 commit into
base: 8.x-3.x
Choose a base branch
from

Conversation

miromichalicka
Copy link

We want to use Lightning packaging mechanisms for packaging our Lightning-based profile. The profile is hosted on GitHub and it's registered on regular Packagist. This PR brings changes, which won't ignore packages which are outside of drupal/ composer namespace.

@phenaproxima
Copy link
Collaborator

phenaproxima commented Oct 15, 2018

Thanks for this pull request!

I'll be very honest: although I'd like @balsama's input here, I'm quite hesitant to merge this. The reason is that the Package.php script in Lightning is emphatically not meant for outside use, and eventually we are hoping to remove it. It is only there to help us package Lightning for distribution on drupal.org -- a mechanism which has been deprecated for a while and is now borderline unsupported. We're trying to go Composer-only once drupal.org allows it (we're pretty much already there, TBH), so any further changes to the packaging script is not something I'd like to encourage. My suggestion would be to just copy the script wholesale into your profile and use/modify it at your leisure, which will give you what you need without requiring us to indefinitely maintain this piece of infrastructure.

That said, if there is enough pushback, and @balsama approves, I can probably be convinced to merge it. But I thought I'd put my 2 cents in now and get the discussion rolling.

@miromichalicka
Copy link
Author

@phenaproxima thanks for feedback. We aren't happy about need for this script either. We need it for Acquia Cloud package unfortunately.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants