Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-19: [self-update] respect proxy settings #1769

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Conversation

danepowell
Copy link
Contributor

Motivation

Fixes #NNN

Proposed changes

Alternatives considered

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. (add specific steps for this pr)

composer.json Outdated Show resolved Hide resolved
@danepowell danepowell added the bug Something isn't working label Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.99%. Comparing base (460cd47) to head (c201dc7).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1769   +/-   ##
=========================================
  Coverage     91.99%   91.99%           
  Complexity     1818     1818           
=========================================
  Files           121      121           
  Lines          6834     6834           
=========================================
  Hits           6287     6287           
  Misses          547      547           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1769/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1769/acli.phar
chmod +x acli.phar

@danepowell
Copy link
Contributor Author

I have no way to verify that the proxy settings actually work, but I did at least verify there are no regressions.

@danepowell danepowell marked this pull request as ready for review July 18, 2024 18:44
@danepowell danepowell merged commit 56d0139 into acquia:main Jul 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant