Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing to setup the nextjs project with command #1084

Merged
merged 4 commits into from
Aug 3, 2022

Conversation

joshirohit100
Copy link
Contributor

@joshirohit100 joshirohit100 commented Jul 13, 2022

Motivation

Fixes https://github.com/acquia/cli/issues/1082 and adds to setup nextjs project from https://github.com/acquia/next-acms as

Proposed changes

command to run -

./bin/acli new

Screenshot 2022-07-13 at 5 15 24 PM

Copy link
Contributor

@danepowell danepowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks like it's 90% of the way there, just needs some cleanup

src/Command/App/NewCommand.php Outdated Show resolved Hide resolved
src/Command/App/NewCommand.php Outdated Show resolved Hide resolved
src/Command/App/NewCommand.php Outdated Show resolved Hide resolved
src/Command/App/NewCommand.php Show resolved Hide resolved
@joshirohit100 joshirohit100 force-pushed the issue-1082 branch 3 times, most recently from 8c9ae50 to 0e4c975 Compare August 2, 2022 04:15
Copy link
Contributor

@danepowell danepowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual testing passed. Everything looks great, please just clean up the remaining nits and I'll merge.

src/Command/App/NewCommand.php Show resolved Hide resolved
src/Command/App/NewCommand.php Outdated Show resolved Hide resolved
src/Command/App/NewCommand.php Outdated Show resolved Hide resolved
src/Command/App/NewCommand.php Outdated Show resolved Hide resolved
@danepowell danepowell merged commit 791162d into acquia:main Aug 3, 2022
@anavarre
Copy link
Contributor

anavarre commented Aug 3, 2022

Exciting stuff @joshirohit100 - thanks for your contribution!

@joshirohit100 joshirohit100 deleted the issue-1082 branch January 14, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI-817: [New] Add a new command (or update existing) to setup the nextjs app for headless
3 participants