Add missing cweagans/composer-patches requirement. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to update composer.lock as well. |
|
Will do. |
|
Er... wrong lock file :/ Updating. |
|
Wait... @grasmash we don't have the composer.lock file generated/committed to BLT for the template directory, so I don't need to update a lock file, correct? |
|
Hm, this is why I was hesitant to remove the lock file. Lightning is failing upstream, and our builds are pulling in the latest version. So, this build fails. |
|
Not sure why this keeps failing... but it keeps failing. |
|
@grasmash - It seems to always be something in Lightning...? |
|
Yeah, this makes me wonder if somehow it's affecting the patches that lightning is applying. |
|
I don't think there was anything wrong with this PR, Travis tests were just a little flaky a few weeks ago. This should be resolved by #191. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...without this, none of the patches defined in
composer.jsonare applied.