Change private files path. #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grasmash
suggested changes
Dec 12, 2016
| @@ -4,7 +4,7 @@ local.* | |||
|
|
|||
| # Ignore paths that contain user-generated content. | |||
| docroot/sites/*/files | |||
| docroot/sites/*/private | |||
| docroot/sites/*/files-private | |||
There was a problem hiding this comment.
Why don't we leave both of these lines in place to cover our all of our bases?
dpagini
force-pushed
the
files-private
branch
from
d6647f3 to
c124e58
Compare
|
Works for me. Fixed as requested, @grasmash. Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed change for the private files path in BLT. Acquia hosting puts private files in a
files-privatedirectory. BLT usesprivatedirectory (inside thesites/*/directory) for the same files. This PR just proposes to align the naming conventions. I know not everyone using BLT uses Acquia, but even within BLT you havefiles-privatementions throughout the code (namely blt/default.local.settings.php)Changes proposed:
.gitignorefilesConsideration: do we need some kind of upgrade task for this type of thing? I'm thinking maybe not b/c of the above mentioned default file.