Removed cloud hook samples. #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grasmash
suggested changes
Nov 16, 2016
There was a problem hiding this comment.
Yeah I've also considered doing this. But, maybe we should have a mechanism for downloading them to the correct directory?
At minimum, we should add a file to the hooks directory with some instructions. Maybe just add a few example commands in https://github.com/acquia/blt/blob/8.x/template/hooks/README.md
|
@grasmash I cleaned up the README a bit. I'm not clear on what kind of additional support we should provide here. It's easy enough to browse the cloud hooks repo and download samples on an as-needed basis. We could add new individual commands to set up things like Slack, Hipchat, or New Relic integration... but it seems like a pretty low ROI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems confusing and unnecessary to me that we maintain local copies of cloud hook samples and templates that are available upstream at https://github.com/acquia/cloud-hooks
If people need these, we have a link to that upstream repo in the docs, it seems like it would be best to just maintain them there.