Move phpunit tests (#295)

.travis.yml

@@ -84,10 +84,12 @@ script:
   - blt deploy:build
   # Add Drupal VM config to repo.
   - blt vm:init
+  # Run the 'blt-project' phpunit tests.
+  - phpunit vendor/acquia/blt/tests/phpunit --group blt-project
   # Switch back to 'blt' directory.
   - cd ../blt
   # Run 'blt' phpunit tests, excluding deploy-push tests.
-  - phpunit tests/phpunit --exclude-group deploy-push
+  - phpunit tests/phpunit --group blt --exclude-group deploy-push
 
 deploy:
   provider: script

composer.json

@@ -13,7 +13,10 @@
     "symfony/console":                  "~2"
   },
   "autoload": {
-    "psr-4": {"Acquia\\Blt\\": "src/"}
+    "psr-4": {
+      "Acquia\\Blt\\": "src/",
+      "Acquia\\Blt\\Tests\\": "tests/phpunit/src/"
+    }
   },
   "bin": [
     "bin/blt",

phing/tasks/tests.xml

@@ -88,6 +88,7 @@
         <fileset dir="${repo.root}/tests/phpunit">
           <include name="**/*Test*.php"/>
         </fileset>
+        <fileset dir="${blt.root}/tests/phpunit/BltProject"/>
       </batchtest>
     </phpunit>
     <phpunitreport infile="${reports.localDir}/phpunit/testsuites.xml" format="noframes" todir="${reports.localDir}/phpunit" />

template/drush.wrapper

@@ -45,7 +45,7 @@ fi
 
 DOCROOT=$(${DIR}/vendor/bin/blt echo-property -Dproperty.name=drush.root -S -e)
 if [ -z "$DOCROOT" ]; then
-  vendor/bin/drush.launcher --alias-path=${DIR}/drush/site-aliases "$@"
+  vendor/bin/drush.launcher --config=${DIR}/drush/drushrc.php --alias-path=${DIR}/drush/site-aliases "$@"
 else
-  vendor/bin/drush.launcher --alias-path=${DIR}/drush/site-aliases "$@" -r $DOCROOT
+  vendor/bin/drush.launcher --config=${DIR}/drush/drushrc.php --alias-path=${DIR}/drush/site-aliases "$@" -r $DOCROOT
 fi

tests/phpunit/BltTest.php → tests/phpunit/Blt/BltTest.php

@@ -1,28 +1,21 @@
 <?php
 
-namespace Drupal;
+namespace Acquia\Blt\Tests\Blt;
 
-use Symfony\Component\Yaml\Yaml;
+use Acquia\Blt\Tests\BltTestBase;
 
 /**
  * Class BLTTest.
  *
  * Verifies that project structure and configuration matches BLT
  * standards.
  */
-class BltTest extends \PHPUnit_Framework_TestCase {
-
-  /**
-   * Class constructor.
-   */
-  public function __construct() {
-    $this->projectDirectory = realpath(dirname(__FILE__) . '/../../');
-    $this->newProjectDir = dirname($this->projectDirectory) . '/blt-project';
-    $this->config = Yaml::parse(file_get_contents("{$this->newProjectDir}/project.yml"));
-  }
+class BltTest extends BltTestBase {
 
   /**
    * Tests Phing pt:create target.
+   *
+   * @group blt
    */
   public function testBltCreate() {
 

tests/phpunit/DeployTest.php → tests/phpunit/Blt/DeployTest.php

@@ -1,31 +1,29 @@
 <?php
 
-namespace Drupal;
+namespace Acquia\Blt\Tests\Blt;
 
-use Symfony\Component\Yaml\Yaml;
+use Acquia\Blt\Tests\BltTestBase;
 
 /**
  * Class DeployTest.
  *
  * Verifies that build artifact matches standards.
  */
-class DeployTest extends \PHPUnit_Framework_TestCase {
+class DeployTest extends BltTestBase {
 
   /**
-   * Class constructor.
+   * {@inheritdoc}
    */
-  public function __construct() {
-
-    $this->projectDirectory = realpath(dirname(__FILE__) . '/../../');
-    $this->newProjectDir = dirname($this->projectDirectory) . '/blt-project';
-    $this->config = Yaml::parse(file_get_contents("{$this->newProjectDir}/project.yml"));
+  public function setUp() {
+    parent::setUp();
     $this->deploy_dir = $this->newProjectDir . '/deploy';
   }
 
   /**
    * Tests Phing deploy:build:all target.
    *
    * @group deploy
+   * @group blt
    */
   public function testBltDeployBuild() {
 
@@ -63,6 +61,7 @@ public function testBltDeployBuild() {
    *
    * @group deploy
    * @group deploy-push
+   * @group blt
    */
   public function testBltDeployPush() {
 

tests/phpunit/DrupalVmTest.php → tests/phpunit/Blt/DrupalVmTest.php

@@ -1,27 +1,20 @@
 <?php
 
-namespace Drupal;
+namespace Acquia\Blt\Tests\Blt;
 
-use Symfony\Component\Yaml\Yaml;
+use Acquia\Blt\Tests\BltTestBase;
 
 /**
  * Class DrupalVM.
  *
  * Verifies that Drupal VM integration works as expected.
  */
-class DrupalVmTest extends \PHPUnit_Framework_TestCase {
-
-  /**
-   * Class constructor.
-   */
-  public function __construct() {
-    $this->projectDirectory = realpath(dirname(__FILE__) . '/../../');
-    $this->newProjectDir = dirname($this->projectDirectory) . '/blt-project';
-    $this->config = Yaml::parse(file_get_contents("{$this->newProjectDir}/project.yml"));
-  }
+class DrupalVmTest extends BltTestBase {
 
   /**
    * Tests Phing vm:init target.
+   *
+   * @group blt
    */
   public function testVmInit() {
     $this->assertFileExists($this->newProjectDir . '/Vagrantfile');

template/tests/phpunit/Bolt/BehatTest.php → tests/phpunit/BltProject/BehatTest.php

@@ -1,16 +1,20 @@
 <?php
 
-namespace Drupal\Tests\PHPUnit;
+namespace Acquia\Blt\Tests\BltProject;
+
+use Acquia\Blt\Tests\BltProjectTestBase;
 
 /**
  * Class BehatTest.
  *
  * Verifies that behat configuration is as expected.
  */
-class BehatTest extends TestBase {
+class BehatTest extends BltProjectTestBase {
 
   /**
    * Tests Phing setup:behat target.
+   *
+   * @group blt-project
    */
   public function testSetupBehat() {
 

template/tests/phpunit/Bolt/BuildTest.php → tests/phpunit/BltProject/BuildTest.php

@@ -1,18 +1,22 @@
 <?php
 
-namespace Drupal\Tests\PHPUnit;
+namespace Acquia\Blt\Tests\BltProject;
+
+use Acquia\Blt\Tests\BltProjectTestBase;
 
 /**
  * Class BuildTest.
  *
  * Verifies that build tasks work as expected.
  */
-class BuildTest extends TestBase {
+class BuildTest extends BltProjectTestBase {
 
   /**
    * Tests Phing setup:make target.
    *
    * This should build /make.yml.
+   *
+   * @group blt-project
    */
   public function testSetupMake() {
 

template/tests/phpunit/Bolt/DrushTest.php → tests/phpunit/BltProject/DrushTest.php

@@ -1,23 +1,29 @@
 <?php
 
-namespace Drupal\Tests\PHPUnit;
+namespace Acquia\Blt\Tests\BltProject;
+
+use Acquia\Blt\Tests\BltProjectTestBase;
 
 /**
  * Class DrushTest.
  *
  * Verifies that git related tasks work as expected.
  */
-class DrushTest extends TestBase {
+class DrushTest extends BltProjectTestBase {
 
   /**
    * Tests that correct drush configuration is loaded.
+   *
+   * @group blt-project
    */
   public function testDrushConfig() {
 
     // We must define the absolute path of the binary because child shell
     // processes in PHP to not inherit $PATH setting from environment.
     $drush_bin = $this->projectDirectory . '/vendor/bin/drush';
-    $command = "$drush_bin status";
+    // Use --format=json output so we don't have to deal with output line
+    // wrapping when running the tests.
+    $command = "$drush_bin status --format=json";
 
     // Test that drush can be run from the following directories.
     $dirs = array(
@@ -29,9 +35,10 @@ public function testDrushConfig() {
     foreach ($dirs as $dir) {
       chdir($dir);
       print "Executing \"$command\" in $dir \n";
-      // If it contains the local URI, we know it is correctly loading
-      // drushrc.php.
-      $this->assertContains($this->config['project']['local']['hostname'], shell_exec($command));
+      $json_output = shell_exec($command);
+      $drush_output = json_decode($json_output, TRUE);
+      // Check for the path to drushrc.php that is included in the project.
+      $this->assertContains($this->projectDirectory . '/drush/drushrc.php', $drush_output['drush-conf']);
     }
   }
 

template/tests/phpunit/Bolt/GitTest.php → tests/phpunit/BltProject/GitTest.php

@@ -1,16 +1,20 @@
 <?php
 
-namespace Drupal\Tests\PHPUnit;
+namespace Acquia\Blt\Tests\BltProject;
+
+use Acquia\Blt\Tests\BltProjectTestBase;
 
 /**
  * Class GitTasksTest.
  *
  * Verifies that git related tasks work as expected.
  */
-class GitTasksTest extends TestBase {
+class GitTasksTest extends BltProjectTestBase {
 
   /**
    * Tests Phing setup:git-hooks target.
+   *
+   * @group blt-project
    */
   public function testGitConfig() {
     $this->assertFileExists($this->projectDirectory . '/.git');
@@ -29,6 +33,8 @@ public function testGitConfig() {
    *   The PHPUnit message to be output for this datapoint.
    *
    * @dataProvider providerTestGitHookCommitMsg
+   *
+   * @group blt-project
    */
   public function testGitHookCommitMsg($is_valid, $commit_message, $message = NULL) {
     $this->assertCommitMessageValidity($is_valid, $commit_message, $message);
@@ -38,7 +44,7 @@ public function testGitHookCommitMsg($is_valid, $commit_message, $message = NULL
    * Data provider.
    */
   public function providerTestGitHookCommitMsg() {
-    $prefix = $this->config['project']['prefix'];
+    $prefix = isset($this->config['project']) ? $this->config['project']['prefix'] : '';
     return array(
       array(FALSE, "This is a bad commit.", 'Missing prefix and ticket number.'),
       array(FALSE, "123: This is a bad commit.", 'Missing project prefix.'),
@@ -57,6 +63,8 @@ public function providerTestGitHookCommitMsg() {
    * Tests operation of scripts/git-hooks/pre-commit.
    *
    * Should assert that code validation via phpcs is functioning.
+   *
+   * @group blt-project
    */
   public function testGitPreCommitHook() {
     // Commits must be executed inside of new project directory.

template/tests/phpunit/Bolt/SettingsTest.php → tests/phpunit/BltProject/SettingsTest.php

@@ -1,13 +1,15 @@
 <?php
 
-namespace Drupal\Tests\PHPUnit;
+namespace Acquia\Blt\Tests\BltProject;
+
+use Acquia\Blt\Tests\BltProjectTestBase;
 
 /**
  * Class SettingsTest.
  *
  * Verifies $settings.php configuration.
  */
-class SettingsTest extends TestBase {
+class SettingsTest extends BltProjectTestBase {
 
   /**
    * Sets up require parameters for tests to run.
@@ -29,6 +31,8 @@ public function setupParams($env) {
 
   /**
    * Test configuration for production environment on ACE.
+   *
+   * @group blt-project
    */
   public function testProd() {
 
@@ -40,6 +44,8 @@ public function testProd() {
 
   /**
    * Tests Phing setup:drupal:settings target.
+   *
+   * @group blt-project
    */
   public function testSetupLocalSettings() {