Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1888: Default to PHP 7.1. #1901

Merged
merged 1 commit into from
Aug 8, 2017
Merged

Conversation

grasmash
Copy link
Contributor

@grasmash grasmash commented Aug 8, 2017

No description provided.

@grasmash
Copy link
Contributor Author

grasmash commented Aug 8, 2017

@danepowell @geerlingguy @mikemadison13 Will this have any notable consequences that I should be aware of?

@grasmash grasmash added the Enhancement A feature or feature request label Aug 8, 2017
@geerlingguy
Copy link
Contributor

@grasmash - You mean, besides everything being like 50% faster? Nope.

@@ -35,6 +35,11 @@
"Acquia\\Blt\\Custom\\": "../../../blt/src/"
}
},
"config": {
"platform": {
"php": "7"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this prevent BLT from being installed or run on host machines using PHP <7?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious about this answer...? Also, if this is the general approach of BLT, can't we undo #1829 as well?

@danepowell
Copy link
Contributor

We should also set up Pipelines to use PHP7:

version: 1.1.0
services:
  - mysql
  - php:
      version: 7.1

We should also make sure to include release notes indicating that the default versions have changed, and folks should re-initialize DrupalVM, Travis, and Pipelines to get the change locally.

@mikemadison13
Copy link
Contributor

People will def. need to change back to 5.6 if not running 7. That will cause problems for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A feature or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants