Allow non-200 connections when waiting for server for tests. #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danepowell
force-pushed
the
feature/run-server-response
branch
from
f0df150 to
c815d20
Compare
danepowell
force-pushed
the
feature/run-server-response
branch
from
c815d20 to
47db1fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when running Behat tests using the built-in php server (the default test setup), BLT waits for a 200 connection before proceeding with tests.
The problem is that not all sites will return a 200 on the homepage, such as Reservoir-based installs that return a 403.
It seems that BLT should accept any connection except for one that might indicate the server is still starting (i.e. 50x).