-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add post-config-import hook. #1108
Conversation
Makes sense. I'm curious how it would be used though. |
@danepowell - my team would like to use it to toggle local modules. For instance, when developing sites we use When we run blt setup:toggle-modules -Dmultisite.name=<site> -Denvironment=local this enables setup:config-import -Dmultisite.name=<site> this will fail because our committed code doesn't list If we had a Has your team run into this issue? I'd be interested to hear how you've been solving it if so. |
There seem to be two general approaches to CM right now. The first is to use Features or partial config imports, which implies not using The second approach is to do full config imports, but use config_split to support varying configuration (including installed modules) by environment. As an example, see @geerlingguy's blog post (especially the first user comment) |
Thanks @danepowell, these alternative approaches are definitely something our team needs to evaluate. |
Yeah I'd also like to see a strong use case presented for this. I'm wary of introducing too many new target-hooks. |
Changes proposed: