Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACMS-000: Fixing border focus issue on menu links. #741

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

aellison
Copy link
Contributor

Motivation
Gold border around focused links causes link to grow larger than container.
Fixes #NNN

Proposed changes
Increase specificity of CSS. Apply "display: block" property only focusable items with a role property of "link".

Alternatives considered
Switching the display of link focus border flex properties. Would have had larger impact that would be hard to test for.

Testing steps

  • Navigate to any page. Use the tab key to add focus to main nav links. Ensure that the link doesn't jump around.
  • Navigate to /search page and search for term that yields results. Tab through facets and ensure that gold border wraps focusable links.

Merge requirements

  • _Bug
  • Manual testing by a reviewer

@msherron msherron merged commit 66d259f into develop Mar 22, 2021
@msherron msherron deleted the ACMS-000-fix-focus-border branch March 22, 2021 23:12
modularlab pushed a commit to emb03/acquia_cms that referenced this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants