-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACMS-1925: Add Starter kit validation. #114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepakmishra2
requested review from
rajeshreeputra,
vishalkhode1 and
apathak18
August 10, 2023 11:19
deepakmishra2
force-pushed
the
ACMS-1925
branch
from
August 10, 2023 13:41
4632128
to
14dfe4b
Compare
rajeshreeputra
force-pushed
the
ACMS-1925
branch
from
August 14, 2023 11:04
6edc5f9
to
f0fb156
Compare
deepakmishra2
force-pushed
the
ACMS-1925
branch
from
August 17, 2023 07:11
fd10be8
to
bb1105c
Compare
deepakmishra2
force-pushed
the
ACMS-1925
branch
from
August 17, 2023 12:31
b596491
to
3925721
Compare
deepakmishra2
force-pushed
the
ACMS-1925
branch
2 times, most recently
from
August 18, 2023 13:43
04ad3e1
to
0318f5a
Compare
apathak18
approved these changes
Aug 18, 2023
deepakmishra2
force-pushed
the
ACMS-1925
branch
from
August 18, 2023 14:09
0318f5a
to
98c9248
Compare
chandan-singh7929
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall changes looks good to me, there's minor suggestions. Please take a look.
deepakmishra2
force-pushed
the
ACMS-1925
branch
from
August 21, 2023 15:32
31b229f
to
351b58c
Compare
deepakmishra2
force-pushed
the
ACMS-1925
branch
from
August 21, 2023 15:34
351b58c
to
b9a5ab8
Compare
deepakmishra2
force-pushed
the
ACMS-1925
branch
from
August 23, 2023 05:47
b45e284
to
e7f8b75
Compare
rajeshreeputra
approved these changes
Aug 23, 2023
chandan-singh7929
approved these changes
Aug 23, 2023
deepakmishra2
force-pushed
the
ACMS-1925
branch
from
August 23, 2023 12:37
d994eb9
to
f414e28
Compare
deepakmishra2
force-pushed
the
ACMS-1925
branch
from
August 23, 2023 13:07
f414e28
to
bbb4488
Compare
apathak18
approved these changes
Aug 23, 2023
vishalkhode1
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #ACMS-1925
Proposed changes
Added validation for starter-kit
Alternatives considered
Testing steps