Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACMS-1925: Add Starter kit validation. #114

Merged
merged 9 commits into from
Aug 24, 2023
Merged

ACMS-1925: Add Starter kit validation. #114

merged 9 commits into from
Aug 24, 2023

Conversation

deepakmishra2
Copy link
Contributor

Motivation

Fixes #ACMS-1925

Proposed changes
Added validation for starter-kit

Alternatives considered

Testing steps

  • checkout to ACMS-1925 branch
  • make changes in your acms/acms.yml file
  • keep name and description field empty
  • run ./bin/acms acms:install command

@deepakmishra2 deepakmishra2 marked this pull request as ready for review August 11, 2023 12:30
src/Validation/StarterKitValidation.php Outdated Show resolved Hide resolved
src/Validation/StarterKitValidation.php Outdated Show resolved Hide resolved
src/Validation/StarterKitValidation.php Outdated Show resolved Hide resolved
src/Validation/StarterKitValidation.php Outdated Show resolved Hide resolved
src/Validation/StarterKitValidation.php Outdated Show resolved Hide resolved
src/Validation/StarterKitValidation.php Outdated Show resolved Hide resolved
Copy link
Contributor

@chandan-singh7929 chandan-singh7929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall changes looks good to me, there's minor suggestions. Please take a look.

src/Validation/StarterKitValidation.php Outdated Show resolved Hide resolved
tests/unit/Helpers/InstallerQuestionsTest.php Outdated Show resolved Hide resolved
tests/unit/CliTest.php Outdated Show resolved Hide resolved
src/Validation/StarterKitValidation.php Outdated Show resolved Hide resolved
src/Validation/StarterKitValidation.php Outdated Show resolved Hide resolved
src/Validation/StarterKitValidation.php Outdated Show resolved Hide resolved
src/Validation/StarterKitValidation.php Outdated Show resolved Hide resolved
src/Helpers/Task/InstallTask.php Outdated Show resolved Hide resolved
src/Helpers/Task/BuildTask.php Outdated Show resolved Hide resolved
@vishalkhode1 vishalkhode1 merged commit 954a43f into develop Aug 24, 2023
@vishalkhode1 vishalkhode1 deleted the ACMS-1925 branch August 24, 2023 18:32
vishalkhode1 added a commit that referenced this pull request Mar 13, 2024
This reverts commit 954a43f, reversing
changes made to 1ed77ce.
vishalkhode1 added a commit that referenced this pull request Mar 26, 2024
This reverts commit 954a43f, reversing
changes made to 1ed77ce.
vishalkhode1 added a commit that referenced this pull request Mar 26, 2024
This reverts commit 954a43f, reversing
changes made to 1ed77ce.
vishalkhode1 added a commit that referenced this pull request Mar 26, 2024
This reverts commit 954a43f, reversing
changes made to 1ed77ce.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants